Bugzilla – Attachment 102357 Details for
Bug 25050
Elasticsearch - authority indexing depends on mapping order
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25050: Adjust marc_records_to_documents to search entire mapping array
Bug-25050-Adjust-marcrecordstodocuments-to-search-.patch (text/plain), 1.67 KB, created by
Andrew Fuerste-Henry
on 2020-04-03 13:05:38 UTC
(
hide
)
Description:
Bug 25050: Adjust marc_records_to_documents to search entire mapping array
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2020-04-03 13:05:38 UTC
Size:
1.67 KB
patch
obsolete
>From 0eb90eb5940b2836593df473b807cce4068ff2e7 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 3 Apr 2020 12:14:27 +0000 >Subject: [PATCH] Bug 25050: Adjust marc_records_to_documents to search entire > mapping array > >There was an assumption in the ES code that match-heading mappings will appear in >a specified portion of the mappings array. > >Certain mappings setups will not meet this assumption. >We need to move our searching up one level > >The key seems to be having a mapping for a complete field, say 150, in both the >match-heading and another field as well as having mappings for ungrouped fields like >150a 150ab etc. > >The unit test coverage should be sufficient for testing > >Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> >--- > Koha/SearchEngine/Elasticsearch.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/SearchEngine/Elasticsearch.pm b/Koha/SearchEngine/Elasticsearch.pm >index 8ee939d2be..19fa2a47fa 100644 >--- a/Koha/SearchEngine/Elasticsearch.pm >+++ b/Koha/SearchEngine/Elasticsearch.pm >@@ -577,7 +577,7 @@ sub marc_records_to_documents { > } > ); > } >- if ( defined @{$mappings}[0] && grep /match-heading/, @{@{$mappings}[0]} ){ >+ if ( @{$mappings} && grep { $_->[0] eq 'match-heading'} @{$mappings} ){ > # Used by the authority linker the match-heading field requires a specific syntax > # that is specified in C4/Heading > my $heading = C4::Heading->new_from_field( $field, undef, 1 ); #new auth heading >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25050
:
102346
|
102347
|
102348
|
102356
|
102357
|
102683
|
102684