Bugzilla – Attachment 102460 Details for
Bug 24964
Do not filter patrons AFTER they have been fetched from the DB (when searching with permissions)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24964: [19.11.x] Fix perl critic warning
Bug-24964-1911x-Fix-perl-critic-warning.patch (text/plain), 921 bytes, created by
Jonathan Druart
on 2020-04-06 14:56:16 UTC
(
hide
)
Description:
Bug 24964: [19.11.x] Fix perl critic warning
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-04-06 14:56:16 UTC
Size:
921 bytes
patch
obsolete
>From 068d6278347ea72bcfef931b0a63403615dc09e4 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 26 Mar 2020 08:53:59 -0400 >Subject: [PATCH] Bug 24964: [19.11.x] Fix perl critic warning > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Utils/DataTables/Members.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Utils/DataTables/Members.pm b/C4/Utils/DataTables/Members.pm >index 7f298d8fa0..95ad8b0a8e 100644 >--- a/C4/Utils/DataTables/Members.pm >+++ b/C4/Utils/DataTables/Members.pm >@@ -172,7 +172,7 @@ sub search { > push @where_args, ($has_permission->{module_bit}) x 2, $has_permission->{subpermission}; > } > >- my $where = " WHERE " . join (" AND ", @where_strs) if @where_strs; >+ my $where = @where_strs ? " WHERE " . join (" AND ", @where_strs) : undef; > my $orderby = dt_build_orderby($dt_params); > > my $limit; >-- >2.20.1
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=102460">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24964
:
101668
|
101669
|
101686
|
101702
|
101813
|
101814
|
101815
|
101820
|
101821
|
101822
|
101823
|
102434
|
102435
|
102457
|
102458
|
102459
| 102460 |
102461