Attachment 102463 Details for Bug 24958 – Bug 24958: Remember last selected tab in SQL reports

[patch] Bug 24958: Remember last selected tab in SQL reports

Bug-24958-Remember-last-selected-tab-in-SQL-report.patch (text/plain), 2.25 KB, created by Owen Leonard on 2020-04-06 15:58:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2020-04-06 15:58:02 UTC

Size: 2.25 KB

patch

obsolete

>From 1ec386639b1b5d94cac0434834840df67bc65b32 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 16 Mar 2020 18:53:10 +0000
>Subject: [PATCH] Bug 24958: Remember last selected tab in SQL reports
>
>This patch modifies the saved reports page so that it remembers, for the
>duration of the browser session, the last active tab.
>
>To test you should have multiple reports in multiple report groups.
>Apply the patch and go to Reports -> Saved reports.
>
> - Select a tab to filter the table of saved reports to a particular
>   report group.
> - Navigate away from the page
> - Return to the save reports page. The tab you previously selected
>   should be selected again.
> - Restart your browser and return to the saved reports page. The tab
>   should no longer be preselected.
>---
> .../prog/en/modules/reports/guided_reports_start.tt              | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index 21738b687e..d5a78726d3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -1376,6 +1376,9 @@
>         }
> 
>         $(document).ready(function(){
>+
>+            var activeTab = Cookies.get("sql_reports_activetab");
>+
>             $("body").on('click',".fetch_chart_data",function(){
>                 if( [% unlimited_total || 0 | $raw %] > 1000 ){
>                     if( confirm("Fetching full chart data for reports with many rows can cause performance issues. Are you sure you with to chart this report?") ){
>@@ -1564,7 +1567,13 @@
>                 }, columns_settings);
> 
>                 var rtabs = $("#tabs").tabs();
>+                if( activeTab ){
>+                    $("#tabs").tabs("option","active", activeTab );
>+                }
>                 rtabs.on("tabsactivate", function(e, ui) {
>+                    var activeTab = ui.newTab.index();
>+                    Cookies.set("sql_reports_activetab", activeTab );
>+
>                     $("#subgroup_filter option").each(function() {
>                         if($(this).val().length > 0) {
>                             $(this).remove();
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24958: 102463 | 102618 | 102940 | 103252 | 105890 | 106168 | 109967 | 110741 | 110785