Attachment 102467 Details for Bug 25046 – Bug 25046: Include borrowers.othernames in SELECT statement

[patch] Bug 25046: Include borrowers.othernames in SELECT statement

Bug-25046-Include-borrowersothernames-in-SELECT-st.patch (text/plain), 1.79 KB, created by Devinim on 2020-04-06 19:50:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Devinim

Created: 2020-04-06 19:50:43 UTC

Size: 1.79 KB

patch

obsolete

>From 94a9089dee30365ecbae6605f4597937f7210a52 Mon Sep 17 00:00:00 2001
>From: Andreas Roussos <a.roussos@dataly.gr>
>Date: Thu, 2 Apr 2020 19:14:57 +0200
>Subject: [PATCH] Bug 25046: Include borrowers.othernames in SELECT statement
>
>In C4/Utils/DataTables/Members.pm, the SELECT statement that fetches
>patron data from the database does not include borrowers.othernames
>in the field list. As a consequence, when the output is in the form
>of a DataTable, the Template Toolkit files that refer to .othernames
>(such as the patron-title.inc include) won't display the information
>from the 'Other name' input field if that field has been filled in.
>
>This patch fixes that.
>
>Test plan:
>0) Have a few patrons with some data in the 'Other name' field.
>1) Perform a generic search in Home > Patrons to ensure you will get
>   a DataTable with results.
>2) Observe that the 'Name' column does not include 'Other name' info.
>3) Apply the patch, and restart Plack if necessary.
>4) Repeat your search: this time you should see the information from
>   the 'Other name' field, it will be next to the patron's First name
>   and within parentheses.
>
>Sponsored-by: Eugenides Foundation Library
>
>Signed-off-by: Devinim <nazli@devinim.com.tr>
>---
> C4/Utils/DataTables/Members.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/C4/Utils/DataTables/Members.pm b/C4/Utils/DataTables/Members.pm
>index b0d1d0b1d7b..5bcd971309b 100644
>--- a/C4/Utils/DataTables/Members.pm
>+++ b/C4/Utils/DataTables/Members.pm
>@@ -77,6 +77,7 @@ sub search {
> 
>     my $select = "SELECT
>         borrowers.borrowernumber, borrowers.surname, borrowers.firstname,
>+        borrowers.othernames,
>         borrowers.flags,
>         borrowers.streetnumber, borrowers.streettype, borrowers.address,
>         borrowers.address2, borrowers.city, borrowers.state, borrowers.zipcode,
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25046: 102304 | 102467 | 102539 | 102540