Attachment 102498 Details for Bug 21190 – Bug 21190: Introduce preferences AuthFailureLog and AuthSuccessLog

[patch] Bug 21190: Introduce preferences AuthFailureLog and AuthSuccessLog

Bug-21190-Introduce-preferences-AuthFailureLog-and.patch (text/plain), 5.61 KB, created by Jonathan Druart on 2020-04-07 10:27:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-04-07 10:27:44 UTC

Size: 5.61 KB

patch

obsolete

>From d95523f3e4ebe36b7dceca1ca7b309bc00eb01e9 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 25 Oct 2019 09:36:03 +0000
>Subject: [PATCH] Bug 21190: Introduce preferences AuthFailureLog and
> AuthSuccessLog
>
>Test plan:
>Run atomic update.
>Check the Logs tab of preferences.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk>
>
>Signed-off-by: Michal Denar <black23@gmail.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> installer/data/mysql/atomicupdate/bug21190.perl     |  9 +++++++++
> installer/data/mysql/sysprefs.sql                   |  2 ++
> .../prog/en/modules/admin/preferences/logs.pref     | 13 +++++++++++++
> 3 files changed, 24 insertions(+)
> create mode 100644 installer/data/mysql/atomicupdate/bug21190.perl
>
>diff --git a/installer/data/mysql/atomicupdate/bug21190.perl b/installer/data/mysql/atomicupdate/bug21190.perl
>new file mode 100644
>index 0000000000..40f08e63a2
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug21190.perl
>@@ -0,0 +1,9 @@
>+$DBversion = 'XXX'; # will be replaced by the RM
>+if( CheckVersion( $DBversion ) ) {
>+    $dbh->do(q|
>+INSERT IGNORE INTO systempreferences (variable,value,explanation,options,type) VALUES ('AuthFailureLog','','If enabled, log authentication failures',NULL,'YesNo'), ('AuthSuccessLog','','If enabled, log successful authentications',NULL,'YesNo' )
>+    |);
>+
>+    SetVersion( $DBversion );
>+    print "Upgrade to $DBversion done (Bug 21190 - Add prefs AuthFailureLog and AuthSuccessLog)\n";
>+}
>diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
>index a15c4c6c95..cb15cf9d31 100644
>--- a/installer/data/mysql/sysprefs.sql
>+++ b/installer/data/mysql/sysprefs.sql
>@@ -62,11 +62,13 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('ArticleRequestsMandatoryFieldsRecordOnly', '', NULL, 'Comma delimited list of required fields for bibs where article requests rule = ''bib_only''', 'multiple'),
> ('AudioAlerts','0','','Enable circulation sounds during checkin and checkout in the staff interface.  Not supported by all web browsers yet.','YesNo'),
> ('AuthDisplayHierarchy','0','','Display authority hierarchies','YesNo'),
>+('AuthFailureLog','',NULL,'If enabled, log authentication failures','YesNo'),
> ('AuthoritiesLog','1',NULL,'If ON, log edit/create/delete actions on authorities.','YesNo'),
> ('AuthorityControlledIndicators','# PERSO_NAME  100 600 696 700 796 800 896\nmarc21, 100, ind1:auth1\nmarc21, 600, ind1:auth1, ind2:thesaurus\nmarc21, 696, ind1:auth1\nmarc21, 700, ind1:auth1\nmarc21, 796, ind1:auth1\nmarc21, 800, ind1:auth1\nmarc21, 896, ind1:auth1\n# CORPO_NAME  110 610 697 710 797 810 897\nmarc21, 110, ind1:auth1\nmarc21, 610, ind1:auth1, ind2:thesaurus\nmarc21, 697, ind1:auth1\nmarc21, 710, ind1:auth1\nmarc21, 797, ind1:auth1\nmarc21, 810, ind1:auth1\nmarc21, 897, ind1:auth1\n# MEETI_NAME    111 611 698 711 798 811 898\nmarc21, 111, ind1:auth1\nmarc21, 611, ind1:auth1, ind2:thesaurus\nmarc21, 698, ind1:auth1\nmarc21, 711, ind1:auth1\nmarc21, 798, ind1:auth1\nmarc21, 811, ind1:auth1\nmarc21, 898, ind1:auth1\n# UNIF_TITLE        130 440 630 699 730 799 830 899\nmarc21, 130, ind1:auth2\nmarc21, 240, , ind2:auth2\nmarc21, 440, , ind2:auth2\nmarc21, 630, ind1:auth2, ind2:thesaurus\nmarc21, 699, ind1:auth2\nmarc21, 730, ind1:auth2\nmarc21, 799, ind1:auth2\nmarc21, 830, , ind2:auth2\nmarc21, 899, ind1:auth2\n# CHRON_TERM    648 \nmarc21, 648, , ind2:thesaurus\n# TOPIC_TERM      650 654 656 657 658 690\nmarc21, 650, , ind2:thesaurus\n# GEOGR_NAME   651 662 691\nmarc21, 651, , ind2:thesaurus\n# GENRE/FORM    655 \nmarc21, 655, , ind2:thesaurus\n\n# UNIMARC: Always copy the indicators from the authority\nunimarc, *, ind1:auth1, ind2:auth2',NULL,'Authority controlled indicators per biblio field','Free'),
> ('AuthorityMergeLimit','50',NULL,'Maximum number of biblio records updated immediately when an authority record has been modified.','integer'),
> ('AuthorityMergeMode','loose','loose|strict','Authority merge mode','Choice'),
> ('AuthoritySeparator','--','10','Used to separate a list of authorities in a display. Usually --','free'),
>+('AuthSuccessLog','',NULL,'If enabled, log successful authentications','YesNo'),
> ('autoBarcode','OFF','incremental|annual|hbyymmincr|EAN13|OFF','Used to autogenerate a barcode: incremental will be of the form 1, 2, 3; annual of the form 2007-0001, 2007-0002; hbyymmincr of the form HB08010001 where HB=Home Branch','Choice'),
> ('AutoCreateAuthorities','0',NULL,'Automatically create authorities that do not exist when cataloging records.','YesNo'),
> ('AutoEmailOpacUser','0',NULL,'Sends notification emails containing new account details to patrons - when account is created.','YesNo'),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref
>index 1703230a17..462871c947 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref
>@@ -78,6 +78,19 @@ Logging:
>                   on: Log
>                   off: "Don't log"
>             - when reports are added, deleted or changed.
>+        -
>+            - pref: AuthFailureLog
>+              choices:
>+                  on: Log
>+                  off: "Don't log"
>+            - " authentication failures"
>+        -
>+            - pref: AuthSuccessLog
>+              choices:
>+                  on: Log
>+                  off: "Don't log"
>+            - " successful authentications"
>+
>     Debugging:
>         -
>             - pref: DumpTemplateVarsIntranet
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 21190: 94713 | 94714 | 94715 | 94717 | 94732 | 94733 | 94734 | 94735 | 94736 | 94805 | 98067 | 98068 | 98069 | 98070 | 98071 | 98072 | 98073 | 98074 | 98110 | 98111 | 98112 | 98113 | 98114 | 98115 | 98116 | 98117 | 98125 | 98133 | 98134 | 98135 | 98136 | 98137 | 98138 | 98139 | 98140 | 98141 | 101971 | 101972 | 101973 | 101974 | 101975 | 101976 | 101977 | 101978 | 101979 | 102493 | 102494 | 102496 | 102497 | 102498 | 102499 | 102500 | 102501 | 102502 | 123540