Bugzilla – Attachment 102519 Details for
Bug 24901
C4::Circulation::transferbook lacks tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24901: Fix tests for 19.11.x
Bug-24901-Fix-tests-for-1911x.patch (text/plain), 3.10 KB, created by
Jonathan Druart
on 2020-04-07 13:37:32 UTC
(
hide
)
Description:
Bug 24901: Fix tests for 19.11.x
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-04-07 13:37:32 UTC
Size:
3.10 KB
patch
obsolete
>From 165e3131ac88d50107aba686c76139de9fbf3544 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 7 Apr 2020 15:37:13 +0200 >Subject: [PATCH] Bug 24901: Fix tests for 19.11.x > >--- > t/db_dependent/Circulation/transferbook.t | 39 ++++++++++++----------- > 1 file changed, 21 insertions(+), 18 deletions(-) > >diff --git a/t/db_dependent/Circulation/transferbook.t b/t/db_dependent/Circulation/transferbook.t >index 042830743c..5bbdb57d20 100644 >--- a/t/db_dependent/Circulation/transferbook.t >+++ b/t/db_dependent/Circulation/transferbook.t >@@ -79,12 +79,13 @@ subtest 'transfer already at destination' => sub { > # We are making sure there is no regression, feel free to change the behavior if needed. > # * Contrary to the POD, if ignore_reserves is not passed (or is false), any item reserve > # found will override all other measures that may prevent transfer and force a transfer. >- AddReserve({ >- branchcode => $item->homebranch, >- borrowernumber => $patron->borrowernumber, >- biblionumber => $item->biblionumber, >- itemnumber => $item->itemnumber, >- }); >+ AddReserve( >+ $item->homebranch, >+ $patron->borrowernumber, >+ $item->biblionumber, >+ undef, undef, undef, undef, undef, undef, >+ $item->itemnumber, >+ ); > > ($dotransfer, $messages ) = transferbook( $library->branchcode, $item->barcode ); > is( $dotransfer, 1, 'Transfer of reserved item succeeded without ignore reserves' ); >@@ -126,12 +127,13 @@ subtest 'transfer an issued item' => sub { > # We are making sure there is no regression, feel free to change the behavior if needed. > # * Contrary to the POD, if ignore_reserves is not passed (or is false), any item reserve > # found will override all other measures that may prevent transfer and force a transfer. >- AddReserve({ >- branchcode => $item->homebranch, >- borrowernumber => $patron->borrowernumber, >- biblionumber => $item->biblionumber, >- itemnumber => $item->itemnumber, >- }); >+ AddReserve( >+ $item->homebranch, >+ $patron->borrowernumber, >+ $item->biblionumber, >+ undef, undef, undef, undef, undef, undef, >+ $item->itemnumber, >+ ); > > ($dotransfer, $messages ) = transferbook( $library->branchcode, $item->barcode ); > is( $dotransfer, 1, 'Transfer of reserved item succeeded without ignore reserves' ); >@@ -158,12 +160,13 @@ subtest 'ignore_reserves flag' => sub { > } > ); > >- AddReserve({ >- branchcode => $item->homebranch, >- borrowernumber => $patron->borrowernumber, >- biblionumber => $item->biblionumber, >- itemnumber => $item->itemnumber, >- }); >+ AddReserve( >+ $item->homebranch, >+ $patron->borrowernumber, >+ $item->biblionumber, >+ undef, undef, undef, undef, undef, undef, >+ $item->itemnumber, >+ ); > > # We are making sure there is no regression, feel free to change the behavior if needed. > # * Contrary to the POD, if ignore_reserves is not passed (or is false), any item reserve >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24901
:
100996
|
100997
|
101007
|
101008
| 102519