Attachment 102533 Details for Bug 24940 – Bug 24940: Serials statistics wizard: order vendor list alphabetically

[patch] Bug 24940: Serials statistics wizard: order vendor list alphabetically

Bug-24940-Serials-statistics-wizard-order-vendor-l.patch (text/plain), 1.48 KB, created by Jonathan Druart on 2020-04-08 08:11:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-04-08 08:11:59 UTC

Size: 1.48 KB

patch

obsolete

>From 34b3d10ffd4c8057530efe30a605eac350342464 Mon Sep 17 00:00:00 2001
>From: David Roberts <david@koha-ptfs.co.uk>
>Date: Fri, 3 Apr 2020 15:23:01 +0000
>Subject: [PATCH] Bug 24940: Serials statistics wizard: order vendor list
> alphabetically
>
>This patch changes the dropdown from being sorted by aqbookseller.id to
>aqbookseller.name
>
>To test:
>1) Add at least 2 vendors:
> - First: ZZZZ
> - Second: AAAA
>2) Add subscriptions for each of the vendors
>3) Check the pull down in the serials statistics wizard and verify it
>lists them as ZZZZ, AAAA
>4) Apply the patch
>5) Re-check the pull down in the wizard and check that the vendors are
>now listed AAAA,ZZZZ
>
>Signed-off-by: Devinim <kohadevinim@devinim.com.tr>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> reports/serials_stats.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/reports/serials_stats.pl b/reports/serials_stats.pl
>index 0c5ed28331..a27c404292 100755
>--- a/reports/serials_stats.pl
>+++ b/reports/serials_stats.pl
>@@ -138,7 +138,8 @@ if($do_it){
>     my $sth = $dbh->prepare("SELECT aqbooksellerid, aqbooksellers.name 
>                                 FROM subscription 
>                                   LEFT JOIN aqbooksellers ON (subscription.aqbooksellerid=aqbooksellers.id ) 
>-                                GROUP BY aqbooksellerid");
>+                                ORDER BY aqbooksellers.name ASC
>+				");
>     $sth->execute();
>     
>     while(my $row = $sth->fetchrow_hashref){
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24940: 102390 | 102401 | 102533