Attachment 102607 Details for Bug 24413 – Bug 24413: Do not remove the restrictions from AddReturn

[patch] Bug 24413: Do not remove the restrictions from AddReturn

Bug-24413-Do-not-remove-the-restrictions-from-AddR.patch (text/plain), 1.50 KB, created by Jonathan Druart on 2020-04-09 09:57:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-04-09 09:57:07 UTC

Size: 1.50 KB

patch

obsolete

>From a265b3d083461aa5cffc4eeafb72509372c90290 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 21 Feb 2020 12:37:44 +0100
>Subject: [PATCH] Bug 24413: Do not remove the restrictions from AddReturn
>
>As we are now removing them from MarkIssueReturned they should not be
>removed from AddReturn as well.
>Also I think this will fix a regression, if $doreturn is not set (in
>case the item is withdrawn and BlockReturnOfWithdrawnItems or the item
>is lost and BlockReturnOfLostItems, and other specific cases).
>---
> C4/Circulation.pm | 10 ----------
> 1 file changed, 10 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 10dd550e07..258acbd9d4 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -2116,16 +2116,6 @@ sub AddReturn {
>             if C4::Context->preference("ReturnLog");
>         }
> 
>-    # Remove any OVERDUES related debarment if the borrower has no overdues
>-    if ( $borrowernumber
>-      && $patron->debarred
>-      && C4::Context->preference('AutoRemoveOverduesRestrictions')
>-      && !Koha::Patrons->find( $borrowernumber )->has_overdues
>-      && @{ GetDebarments({ borrowernumber => $borrowernumber, type => 'OVERDUES' }) }
>-    ) {
>-        DelUniqueDebarment({ borrowernumber => $borrowernumber, type => 'OVERDUES' });
>-    }
>-
>     # Check if this item belongs to a biblio record that is attached to an
>     # ILL request, if it is we need to update the ILL request's status
>     if (C4::Context->preference('CirculateILL')) {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24413: 99111 | 99369 | 102606 | 102607 | 104843 | 104844 | 104845 | 104859 | 104860 | 104861 | 105205 | 105206 | 105207 | 105323