Attachment 102649 Details for Bug 25097 – Bug 25097: Add option to message_queue to allow for only specific sending notices

[patch] Bug 25097: Add option to message_queue to allow for only specific sending notices

Bug-25097-Add-option-to-messagequeue-to-allow-for-.patch (text/plain), 2.72 KB, created by Andrew Fuerste-Henry on 2020-04-09 15:52:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Fuerste-Henry

Created: 2020-04-09 15:52:48 UTC

Size: 2.72 KB

patch

obsolete

>From 1eae2407e14eba9187cc683d6d43979f28646d5d Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 9 Apr 2020 11:23:04 -0400
>Subject: [PATCH] Bug 25097: Add option to message_queue to allow for only
> specific sending notices
>
>The message_queue.pl currently will send all the messages queued up.  It would be nice to have some control over which messages are to be sent.
>
>Example: We have libraries who only wanted to send 'hold notices' but not overdue, advance notice, etc during the covid-19 quarantine.  And some that were the opposite - turn off hold notices, but send other generated notices.
>
>Test Plan:
>1) Apply this patch
>2) Enqueue some messages with different letter codes
>3) Run process_message_queue.pl with the new -c parameter using one of the letter codes enqueued
>4) Note that only the messages with the selected code were processed!
>
>Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
>---
> misc/cronjobs/process_message_queue.pl | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
>diff --git a/misc/cronjobs/process_message_queue.pl b/misc/cronjobs/process_message_queue.pl
>index 73cbc9a7ac..8238483108 100755
>--- a/misc/cronjobs/process_message_queue.pl
>+++ b/misc/cronjobs/process_message_queue.pl
>@@ -38,6 +38,7 @@ my $method = 'LOGIN';
> my $help = 0;
> my $verbose = 0;
> my $type = q{};
>+my $letter_code;
> 
> GetOptions(
>     'u|username:s'      => \$username,
>@@ -47,6 +48,7 @@ GetOptions(
>     'h|help|?'          => \$help,
>     'v|verbose'         => \$verbose,
>     't|type:s'          => \$type,
>+    'c|code:s'          => \$letter_code,
> );
> my $usage = << 'ENDUSAGE';
> 
>@@ -60,6 +62,7 @@ This script has the following parameters :
>     -u --username: username of mail account
>     -p --password: password of mail account
>     -t --type: If supplied, only processes this type of message ( email, sms )
>+    -c --code: If supplied, only processes messages with this letter code
>     -l --limit: The maximum number of messages to process for this run
>     -m --method: authentication method required by SMTP server (See perldoc Sendmail.pm for supported authentication types.)
>     -h --help: this message
>@@ -89,12 +92,13 @@ if ( C4::Context->preference('UseKohaPlugins') && C4::Context->config("enable_pl
> 
> C4::Letters::SendQueuedMessages(
>     {
>-        verbose  => $verbose,
>-        username => $username,
>-        password => $password,
>-        method   => $method,
>-        limit    => $limit,
>-        type     => $type,
>+        verbose     => $verbose,
>+        username    => $username,
>+        password    => $password,
>+        method      => $method,
>+        limit       => $limit,
>+        type        => $type,
>+        letter_code => $letter_code,
>     }
> );
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25097: 102646 | 102649 | 106101