Attachment 10274 Details for Bug 7805 – Patch for perlcritic comments

[patch] Patch for perlcritic comments

patch.txt (text/plain), 1.75 KB, created by Marcel de Rooy on 2012-06-14 10:49:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2012-06-14 10:49:52 UTC

Size: 1.75 KB

patch

obsolete

>From c2d79f500e77017f81ad2642d7d04476e7cfa73c Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 14 Jun 2012 12:40:08 +0200
>Subject: [PATCH] 7805 Followup for perlcritic messages
>Content-Type: text/plain; charset="utf-8"
>
>---
> C4/VirtualShelves.pm |   15 +++------------
> 1 files changed, 3 insertions(+), 12 deletions(-)
>
>diff --git a/C4/VirtualShelves.pm b/C4/VirtualShelves.pm
>index 8ecb603..abe8b90 100644
>--- a/C4/VirtualShelves.pm
>+++ b/C4/VirtualShelves.pm
>@@ -221,7 +221,7 @@ Returns the above-mentioned fields for passed virtual shelf number.
> 
> =cut
> 
>-sub GetShelf ($) {
>+sub GetShelf {
>     my ($shelfnumber) = @_;
>     my $query = qq(
>         SELECT shelfnumber, shelfname, owner, category, sortfield,
>@@ -252,7 +252,7 @@ from C4::Circulation.
> 
> =cut
> 
>-sub GetShelfContents ($;$$$) {
>+sub GetShelfContents {
>     my ($shelfnumber, $row_count, $offset, $sortfield) = @_;
>     my $dbh=C4::Context->dbh();
>     my $sth1 = $dbh->prepare("SELECT count(*) FROM virtualshelfcontents WHERE shelfnumber = ?");
>@@ -351,7 +351,7 @@ sub AddToShelf {
>     my $sth = $dbh->prepare($query);
> 
>     $sth->execute( $shelfnumber, $biblionumber );
>-    ($sth->rows) and return undef; # already on shelf
>+    ($sth->rows) and return; # already on shelf
>     $query = qq(
>         INSERT INTO virtualshelfcontents
>             (shelfnumber, biblionumber, flags, borrowernumber)
>@@ -658,15 +658,6 @@ sub _biblionumber_sth { #only used in obsolete sub below
>     $sth;
> }
> 
>-sub each_biblionumbers (&$) { #OBSOLETE
>-    my ($code,$shelf) = @_;
>-    my $ref =  _biblionumber_sth($shelf)->fetchall_arrayref;
>-    map {
>-        $_=$$_[0];
>-        $code->();
>-        } @$ref;
>-}
>-
> sub _CheckShelfName {
>     my ($name, $cat, $owner, $number)= @_;
> 
>-- 
>1.7.7.6
>

Actions: View | Diff | Splinter Review

Attachments on bug 7805: 8529 | 9387 | 9805 | 10274 | 11417 | 13288 | 13289