Attachment 102783 Details for Bug 22784 – Bug 22784: Do not display an empty table

[patch] Bug 22784: Do not display an empty table

Bug-22784-Do-not-display-an-empty-table.patch (text/plain), 1.30 KB, created by Katrin Fischer on 2020-04-12 23:10:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-04-12 23:10:12 UTC

Size: 1.30 KB

patch

obsolete

>From 5a8cc768561a7c81c71c405eac48c72f71865728 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 18 Nov 2019 15:16:24 +0100
>Subject: [PATCH] Bug 22784: Do not display an empty table
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This is terrible and highlight that the whole script must be rewrite.
>GetDistinctValues does not handle the "archived" flag (and we do not
>want to put our hands there), so let's hack that and plan to rewrite the
>whole script.
>
>Signed-off-by: SÃ©verine QUEUNE <severine.queune@bulac.fr>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> suggestion/suggestion.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl
>index 464badb138..4f5c915e53 100755
>--- a/suggestion/suggestion.pl
>+++ b/suggestion/suggestion.pl
>@@ -370,7 +370,7 @@ if ($op=~/else/) {
>                             "suggestionscount"=>scalar(@$suggestions),             
>                             'suggestions_loop'=>$suggestions,
>                             'reasonsloop'     => $reasonsloop,
>-                            };
>+                            } if @$suggestions;
> 
>         delete $$suggestion_ref{$displayby} unless $definedvalue;
>     }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22784: 95499 | 95500 | 95501 | 95502 | 95510 | 95511 | 95512 | 95513 | 95533 | 95534 | 95535 | 95536 | 95537 | 95538 | 96900 | 96901 | 96902 | 96903 | 96904 | 96905 | 100806 | 100807 | 100808 | 100809 | 100810 | 100811 | 100854 | 100855 | 100856 | 100857 | 100858 | 100859 | 101948 | 102779 | 102780 | 102781 | 102782 | 102783 | 102784 | 102785 | 102786 | 102944