Bugzilla – Attachment 102789 Details for
Bug 20370
Misleading comment for bcrypt - #encrypt it; Instead it should be #hash it
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20370: Misleading comment for bcrypt - #encrypt it; Instead it should be #hash it
Bug-20370-Misleading-comment-for-bcrypt---encrypt-.patch (text/plain), 916 bytes, created by
David Roberts
on 2020-04-13 01:24:33 UTC
(
hide
)
Description:
Bug 20370: Misleading comment for bcrypt - #encrypt it; Instead it should be #hash it
Filename:
MIME Type:
Creator:
David Roberts
Created:
2020-04-13 01:24:33 UTC
Size:
916 bytes
patch
obsolete
>From 74f0de344929d253f4cee1d0e81239e7d2d21f1c Mon Sep 17 00:00:00 2001 >From: David Roberts <david@koha-ptfs.co.uk> >Date: Mon, 13 Apr 2020 01:22:07 +0000 >Subject: [PATCH] Bug 20370: Misleading comment for bcrypt - #encrypt it; > Instead it should be #hash it > >This patch changes the wording of the comment > >To test: > >1) Check the wording of Line 67 of Koha/AuthUtils.pm >2) Apply the patch >3) Check that the wording has changed from "Encrypt it" to "Hash it" >--- > Koha/AuthUtils.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/AuthUtils.pm b/Koha/AuthUtils.pm >index d834536357..7c4dcd1002 100644 >--- a/Koha/AuthUtils.pm >+++ b/Koha/AuthUtils.pm >@@ -64,7 +64,7 @@ sub hash_password { > # Set the cost to 8 and append a NULL > $settings = '$2a$08$'.en_base64(generate_salt('weak', 16)); > } >- # Encrypt it >+ # Hash it > return bcrypt($password, $settings); > } > >-- >2.11.0
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=102789">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20370
:
102789
|
102858