Attachment 102794 Details for Bug 22468 – Bug 22468: Standardize on labelling ccode table columns as Collections

[patch] Bug 22468: Standardize on labelling ccode table columns as Collections

Bug-22468-Standardize-on-labelling-ccode-table-col.patch (text/plain), 9.79 KB, created by Katrin Fischer on 2020-04-13 02:38:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-04-13 02:38:12 UTC

Size: 9.79 KB

patch

obsolete

>From 64b6b15c88864a383db8e075c0485345a4e0f537 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Mon, 13 Apr 2020 04:32:56 +0200
>Subject: [PATCH] Bug 22468: Standardize on labelling ccode table columns as
> Collections
>
>We now display the descriptions everywhere, so we should drop the
>'code' from labels.
>
>This changes text in a lot of playes in Koha, including:
>
>- The relatives checkouts table when displayed for the guarantor
>- The new order and order receive forms in acquisitoins (item creation)
>- The description of CCODE in the authorised values table
>- The column description on results in item search
>- The branch tranfers page
>- Course reserves: add reserve items (one and in batch)
>- Patron account > statistics tab
>---
> .../prog/en/includes/relatives-issues-table.inc | 2 +-
> .../intranet-tmpl/prog/en/modules/acqui/neworderempty.tt | 2 +-
> .../intranet-tmpl/prog/en/modules/acqui/orderreceive.tt | 4 ++--
> .../prog/en/modules/admin/authorised_values.tt | 2 +-
> .../intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt | 6 +++---
> .../intranet-tmpl/prog/en/modules/circ/branchtransfers.tt | 4 ++--
> .../prog/en/modules/course_reserves/add_items-step2.tt | 2 +-
> .../prog/en/modules/course_reserves/batch_add_items.tt | 2 +-
> .../intranet-tmpl/prog/en/modules/members/statistics.tt | 2 +-
> 9 files changed, 13 insertions(+), 13 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/relatives-issues-table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/relatives-issues-table.inc
>index 97e9ba6bd1..c13d0456f1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/relatives-issues-table.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/relatives-issues-table.inc
>@@ -9,7 +9,7 @@
> <th scope="col">Title</th>
> <th scope="col">Record-level item type</th>
> <th scope="col">Item type</th>
>- <th scope="col">Collection code</th>
>+ <th scope="col">Collection</th>
> <th scope="col">Location</th>
> <th scope="col">Checked out on (hidden, unformatted)</th>
> <th scope="col">Checked out on</th>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>index 40a4aff187..ed546f7515 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>@@ -268,7 +268,7 @@
> <th>Call number</th>
> <th>Copy number</th>
> <th>Inventory number</th>
>- <th>Collection code</th>
>+ <th>Collection</th>
> <th>Item type</th>
> <th>Materials</th>
> <th>Notes</th>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>index d8972708cd..0efdc69062 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>@@ -126,7 +126,7 @@
> <th>Call number</th>
> <th>Copy number</th>
> <th>Inventory number</th>
>- <th>Collection code</th>
>+ <th>Collection</th>
> <th>Item type</th>
> <th>Materials</th>
> <th>Notes</th>
>@@ -169,7 +169,7 @@
> <th>Call number</th>
> <th>Copy number</th>
> <th>Inventory number</th>
>- <th>Collection code</th>
>+ <th>Collection</th>
> <th>Item type</th>
> <th>Materials</th>
> <th>Notes</th>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>index 8f71938964..56eb1d4c33 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>@@ -349,7 +349,7 @@
> [% CASE 'CAND' %]
> 
> [% CASE 'CCODE' %]
>- Collection codes (appears when cataloging and working with items)
>+ Collections (appear when cataloging and working with items)
> [% CASE 'cn_source' %]
> 
> [% CASE 'CONTROL_NUM_SEQUENCE' %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt
>index b6e263b38a..b1fa37e812 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt
>@@ -12,7 +12,7 @@
> [% CASE 'author' %]Author
> [% CASE 'publishercode' %]Publisher
> [% CASE 'publicationyear' %]Publication date
>- [% CASE 'collectiontitle' %]Collection
>+ [% CASE 'collectiontitle' %]Collection title
> [% CASE 'isbn' %]ISBN
> [% CASE 'issn' %]ISSN
> [% CASE 'homebranch' %]Home library
>@@ -22,8 +22,8 @@
> [% CASE 'All locations' %]All locations
> [% CASE 'itype' %]Item type
> [% CASE 'All item types' %]All item types
>- [% CASE 'ccode' %]Collection code
>- [% CASE 'All collection codes' %]All collection codes
>+ [% CASE 'ccode' %]Collection
>+ [% CASE 'All collection codes' %]All collections
> [% CASE 'notforloan' %]Status
> [% CASE 'All statuses' %]All statuses
> [% CASE 'damaged' %]Damaged
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
>index 4859333a3b..3e7f9e936f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
>@@ -125,7 +125,7 @@
> [% IF ( Koha.Preference('BranchTransferLimitsType') == 'itemtype' ) %]
> <li>Item type: [% ItemTypes.GetDescription( errmsgloo.code ) | html %]</li>
> [% ELSE %]
>- <li>Collection code: [% AuthorisedValues.GetByCode( 'CCODE', errmsgloo.code ) | html %]</li>
>+ <li>Collection: [% AuthorisedValues.GetByCode( 'CCODE', errmsgloo.code ) | html %]</li>
> [% END %]
> <li>Destination library: [% Branches.GetName( errmsgloo.tbr ) | html %]</li>
> </ol>
>@@ -180,7 +180,7 @@
> <th class="tf-location">Shelving location</th>
> <th class="tf-itemcallnumber">Call number</th>
> <th class="tf-itemtype">Item type</th>
>- <th class="tf-ccode">Collection code</th>
>+ <th class="tf-ccode">Collection</th>
> <th class="tf-destination">Destination</th>
> </tr>
> [% FOREACH trsfitemloo IN trsfitemloop %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt
>index 919c7d57c6..061821d708 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt
>@@ -54,7 +54,7 @@
> [% END %]
> 
> <li>
>- <label class="required" for="ccode">Collection code:</label>
>+ <label class="required" for="ccode">Collection:</label>
> <select id="ccode" name="ccode">
> <option value="">LEAVE UNCHANGED</option>
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/batch_add_items.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/batch_add_items.tt
>index ce67aab3ff..068c6bafcb 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/batch_add_items.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/batch_add_items.tt
>@@ -46,7 +46,7 @@
> [% END %]
> 
> <li>
>- <label class="required" for="ccode">Collection code:</label>
>+ <label class="required" for="ccode">Collection:</label>
> <select id="ccode" name="ccode">
> <option value="">LEAVE UNCHANGED</option>
> [% FOREACH c IN AuthorisedValues.Get('CCODE') %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt
>index f79f36c85c..248714b01c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt
>@@ -41,7 +41,7 @@
> [% CASE 'itype' %]
> Item type
> [% CASE 'ccode' %]
>- Collection code
>+ Collection
> [% CASE 'location' %]
> Shelving location
> [% CASE 'homebranch' %]
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 22468: 102794 | 102931 | 102979