Bugzilla – Attachment 10281 Details for
Bug 8092
Koha should use CHI caching framework
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8092 follow-up: Fix perlcritic violations
Bug-8092-follow-up-Fix-perlcritic-violations.patch (text/plain), 1.09 KB, created by
Jared Camins-Esakov
on 2012-06-14 15:45:48 UTC
(
hide
)
Description:
Bug 8092 follow-up: Fix perlcritic violations
Filename:
MIME Type:
Creator:
Jared Camins-Esakov
Created:
2012-06-14 15:45:48 UTC
Size:
1.09 KB
patch
obsolete
>From 108f72d6953b736acc21b473544ab8ad3ae9860e Mon Sep 17 00:00:00 2001 >From: Jared Camins-Esakov <jcamins@cpbibliography.com> >Date: Thu, 14 Jun 2012 11:24:27 -0400 >Subject: [PATCH] Bug 8092 follow-up: Fix perlcritic violations >Content-Type: text/plain; charset="UTF-8" > >Apparently you are not supposed to use "return undef;" or perlcritic >gets mad. Sorry, perlcritic! >--- > Koha/Cache/Fastmmap.pm | 2 +- > Koha/Cache/Memory.pm | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Cache/Fastmmap.pm b/Koha/Cache/Fastmmap.pm >index bad19f5..c5838f0 100644 >--- a/Koha/Cache/Fastmmap.pm >+++ b/Koha/Cache/Fastmmap.pm >@@ -35,7 +35,7 @@ sub _cache_handle { > cache_size => $params->{'cachesize'} || '1m', > ); > } else { >- return undef; >+ return; > } > } > >diff --git a/Koha/Cache/Memory.pm b/Koha/Cache/Memory.pm >index da09765..1ed1096 100644 >--- a/Koha/Cache/Memory.pm >+++ b/Koha/Cache/Memory.pm >@@ -36,7 +36,7 @@ sub _cache_handle { > global => 1, > ); > } else { >- return undef; >+ return; > } > } > >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8092
:
9593
|
9595
|
9664
|
9802
|
10037
|
10093
| 10281