Attachment 102813 Details for Bug 25123 – Bug 25123: Count the current fine when reducing for maxFine

[patch] Bug 25123: Count the current fine when reducing for maxFine

Bug-25123-Count-the-current-fine-when-reducing-for.patch (text/plain), 1.42 KB, created by Nick Clemens (kidclamp) on 2020-04-13 11:40:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2020-04-13 11:40:22 UTC

Size: 1.42 KB

patch

obsolete

>From c27bbd3c079a9889fc0a6859298bc4f1fcc06248 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 13 Apr 2020 11:38:28 +0000
>Subject: [PATCH] Bug 25123: Count the current fine when reducing for maxFine
>
>If maxFine is set, we total the patrons outstanding fines when making an adjustment, however, we neglect to count the amount of a currently updating fine when doing so.
>
>To test:
>1 - Set maxFine to 5
>2 - Create an overdue amount of 4.99 for a patron
>3 - Set an itemtype to have a fine of $.10 per day
>4 - Checkout an item of that type to a patron and backdate the due date so it is overdue
>5 - Run fines.pl with -v
>6 - Note the fine is reduced from $.10 (or a multiple) to .01
>7 - Run it again, a second cent is added
>8 - Repeat and note it keeps happening until the amount of the fine is reached, exceeding the maxFine setting
>9 - Apply patch
>10 - Note the fine is now reduced to 0 and nothing is added to account
>---
> C4/Overdues.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/C4/Overdues.pm b/C4/Overdues.pm
>index 2f1212ba0c..2985d848a5 100644
>--- a/C4/Overdues.pm
>+++ b/C4/Overdues.pm
>@@ -551,6 +551,7 @@ sub UpdateFine {
>                 #FIXME Should we still count this one in total_amount ??
>             }
>             else {
>+                $total_amount_other += $overdue->amountoutstanding; #We still count it
>                 $accountline = $overdue;
>                 next;
>             }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25123: 102812 | 102813 | 102920 | 103232 | 103233 | 103234 | 103294 | 103295 | 103296