Attachment 102841 Details for Bug 25109 – Bug 25109: Add entry in about.pl about the configuration lockdir entry

[patch] Bug 25109: Add entry in about.pl about the configuration lockdir entry

Bug-25109-Add-entry-in-aboutpl-about-the-configura.patch (text/plain), 1.89 KB, created by Kyle M Hall (khall) on 2020-04-13 13:46:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-04-13 13:46:20 UTC

Size: 1.89 KB

patch

obsolete

>From 1988386c4c180fbf4f230b496434afbd437a0ced Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 10 Apr 2020 19:36:41 -0300
>Subject: [PATCH] Bug 25109: Add entry in about.pl about the configuration
> lockdir entry
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> about.pl                                         | 6 ++++++
> koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 7 +++++++
> 2 files changed, 13 insertions(+)
>
>diff --git a/about.pl b/about.pl
>index f0ae48de97..85e55cb0c0 100755
>--- a/about.pl
>+++ b/about.pl
>@@ -209,6 +209,12 @@ if ( ! defined C4::Context->config('log4perl_conf') ) {
>     }
> }
> 
>+if ( ! defined C4::Context->config('lockdir') ) {
>+    push @xml_config_warnings, {
>+        error => 'lockdir_entry_missing'
>+    }
>+}
>+
> if ( ! defined C4::Context->config('upload_path') ) {
>     if ( Koha::Config::SysPrefs->find('OPACBaseURL')->value ) {
>         # OPACBaseURL seems to be set
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>index ef60aed2b7..341a618232 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>@@ -359,6 +359,13 @@
>                         add it, pointing to the log4perl.conf file for your Koha instance.
>                     </td>
>                 </tr>
>+                [% ELSIF config_entry.error == 'lockdir_entry_missing' %]
>+                <tr>
>+                    <th scope="row"><b>Warning</b></th>
>+                    <td>You are missing the &lt;lockdir&gt; entry in your koha-conf.xml file. Please
>+                        add it, pointing to your Koha instance's lock dir.
>+                    </td>
>+                </tr>
>                 [% ELSIF config_entry.error == 'uploadpath_entry_missing' %]
>                 <tr>
>                     <th scope="row"><b>Warning</b></th>
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 25109: 102757 | 102758 | 102759 | 102760 | 102761 | 102762 | 102814 | 102815 | 102816 | 102817 | 102840 | 102841 | 102842 | 102843 | 102856 | 102887 | 102904 | 102905 | 102906 | 102907 | 102908 | 102909