Attachment 102858 Details for Bug 20370 – Bug 20370: Misleading comment for bcrypt - #encrypt it; Instead it should be #hash it

[patch] Bug 20370: Misleading comment for bcrypt - #encrypt it; Instead it should be #hash it

Bug-20370-Misleading-comment-for-bcrypt---encrypt-.patch (text/plain), 974 bytes, created by Katrin Fischer on 2020-04-13 15:14:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-04-13 15:14:36 UTC

Size: 974 bytes

patch

obsolete

>From 34c0d03b7a5deae7be63fa40682b44ea93e1d09f Mon Sep 17 00:00:00 2001
>From: David Roberts <david@koha-ptfs.co.uk>
>Date: Mon, 13 Apr 2020 01:22:07 +0000
>Subject: [PATCH] Bug 20370: Misleading comment for bcrypt - #encrypt it;
> Instead it should be #hash it
>
>This patch changes the wording of the comment
>
>To test:
>
>1) Check the wording of Line 67 of Koha/AuthUtils.pm
>2) Apply the patch
>3) Check that the wording has changed from "Encrypt it" to "Hash it"
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> Koha/AuthUtils.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/AuthUtils.pm b/Koha/AuthUtils.pm
>index d834536357..7c4dcd1002 100644
>--- a/Koha/AuthUtils.pm
>+++ b/Koha/AuthUtils.pm
>@@ -64,7 +64,7 @@ sub hash_password {
>     # Set the cost to 8 and append a NULL
>         $settings = '$2a$08$'.en_base64(generate_salt('weak', 16));
>     }
>-    # Encrypt it
>+    # Hash it
>     return bcrypt($password, $settings);
> }
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20370: 102789 | 102858