Bugzilla – Attachment 10286 Details for
Bug 8247
adding basket doesn't save basket name, internal or vendor note
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 8247 - adding basket doesn't save basket name, internal or vendor note
SIGNED-OFF-Bug-8247---adding-basket-doesnt-save-ba.patch (text/plain), 1.77 KB, created by
Marc Véron
on 2012-06-14 18:29:27 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 8247 - adding basket doesn't save basket name, internal or vendor note
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2012-06-14 18:29:27 UTC
Size:
1.77 KB
patch
obsolete
>From db24485991fb23b448d1d4151e3ff91a5949f22b Mon Sep 17 00:00:00 2001 >From: Dobrica Pavlinusic <dpavlin@rot13.org> >Date: Thu, 14 Jun 2012 17:17:52 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 8247 - adding basket doesn't save basket name, internal or vendor note >Content-Type: text/plain; charset="utf-8" > >URL: /cgi-bin/koha/acqui/basketheader.pl?booksellerid=32&op=add_form > >I'm also getting mysql referential integrity error: > >DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_srvgit`.`aqbasket`, CONSTRAINT `aqbasket_ibfk_1` FOREIGN KEY (`booksellerid`) REFERENCES `aqbooksellers` (`id`) ON UPDATE CASCADE) at /srv/koha/C4/Acquisition.pm line 416. > >Test scenario: > >1. Find vendor and select "New basket" >2. fill in basket name, internal and vendor note >3. press save >4. verify that created basket doesn't have name nor internal or vendor notes > >Signed-off-by: Marc Veron <veron@veron.ch> > >First tested without patch applied, new basket's name and internal / vendor notes were empty- >Applied patch, new basket's name and notes behave OK. >--- > C4/Acquisition.pm | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index 52f5545..ccb488b 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -193,7 +193,7 @@ sub NewBasket { > $dbh->do($query); > #find & return basketno MYSQL dependant, but $dbh->last_insert_id always returns null :-( > my $basket = $dbh->{'mysql_insertid'}; >- ModBasketHeader($basket, $basketname || '', $basketnote || '', $basketbooksellernote || '', $basketcontractnumber || undef); >+ ModBasketHeader($basket, $basketname || '', $basketnote || '', $basketbooksellernote || '', $basketcontractnumber || undef, $booksellerid); > return $basket; > } > >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8247
:
10280
| 10286