Attachment 102909 Details for Bug 25109 – Bug 25109: (QA follow-up) Add a test for lockdir writable in about.pl

[patch] Bug 25109: (QA follow-up) Add a test for lockdir writable in about.pl

Bug-25109-QA-follow-up-Add-a-test-for-lockdir-writ.patch (text/plain), 2.02 KB, created by Jonathan Druart on 2020-04-14 08:36:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-04-14 08:36:14 UTC

Size: 2.02 KB

patch

obsolete

>From badbebfb345b3c5e3528e95abe45849a7f685511 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 13 Apr 2020 15:45:50 -0300
>Subject: [PATCH] Bug 25109: (QA follow-up) Add a test for lockdir writable in
> about.pl
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> about.pl                                         | 8 ++++++++
> koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 7 +++++++
> 2 files changed, 15 insertions(+)
>
>diff --git a/about.pl b/about.pl
>index 85e55cb0c0..dc25550fd2 100755
>--- a/about.pl
>+++ b/about.pl
>@@ -214,6 +214,14 @@ if ( ! defined C4::Context->config('lockdir') ) {
>         error => 'lockdir_entry_missing'
>     }
> }
>+else {
>+    unless ( -w C4::Context->config('lockdir') ) {
>+        push @xml_config_warnings, {
>+            error   => 'lockdir_not_writable',
>+            lockdir => C4::Context->config('lockdir')
>+        }
>+    }
>+}
> 
> if ( ! defined C4::Context->config('upload_path') ) {
>     if ( Koha::Config::SysPrefs->find('OPACBaseURL')->value ) {
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>index 341a618232..d8f0dfa01b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>@@ -366,6 +366,13 @@
>                         add it, pointing to your Koha instance's lock dir.
>                     </td>
>                 </tr>
>+                [% ELSIF config_entry.error == 'lockdir_not_writable' %]
>+                <tr>
>+                    <th scope="row"><b>Warning</b></th>
>+                    <td>The configured &lt;lockdir&gt; entry in your koha-conf.xml file points to a
>+                        non-writable directory ([% config_entry.lockdir | html %]).
>+                    </td>
>+                </tr>
>                 [% ELSIF config_entry.error == 'uploadpath_entry_missing' %]
>                 <tr>
>                     <th scope="row"><b>Warning</b></th>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25109: 102757 | 102758 | 102759 | 102760 | 102761 | 102762 | 102814 | 102815 | 102816 | 102817 | 102840 | 102841 | 102842 | 102843 | 102856 | 102887 | 102904 | 102905 | 102906 | 102907 | 102908 | 102909