Attachment 102912 Details for Bug 23571 – bug 23571: (QA follow-up) Remove perlcritic warning

[patch] bug 23571: (QA follow-up) Remove perlcritic warning

bug-23571-QA-follow-up-Remove-perlcritic-warning.patch (text/plain), 1023 bytes, created by Jonathan Druart on 2020-04-14 08:37:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-04-14 08:37:06 UTC

Size: 1023 bytes

patch

obsolete

>From 52ff5b65e800d5525786e8028805c49c450fb969 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 14 Apr 2020 10:18:31 +0200
>Subject: [PATCH] bug 23571: (QA follow-up) Remove perlcritic warning
>
>Bareword file handle opened at line 138, column 5.  See pages 202,204 of PBP.  (Severity: 5)
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> Koha/Script.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Script.pm b/Koha/Script.pm
>index 089cebf1a7..aaa2e8b560 100644
>--- a/Koha/Script.pm
>+++ b/Koha/Script.pm
>@@ -135,7 +135,7 @@ sub lock_exec {
> 
>     my $lock_params = ($params->{wait}) ? LOCK_EX : LOCK_EX | LOCK_NB;
> 
>-    open our $lock_handle, '>', $self->{lock_file}
>+    open my $lock_handle, '>', $self->{lock_file}
>         or Koha::Exceptions::Exception->throw("Unable to open the lock file ".$self->{lock_file}.": $!");
>     $self->{lock_handle} = $lock_handle;
>     flock( $lock_handle, $lock_params )
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 23571: 96055 | 96056 | 98898 | 98899 | 99263 | 99264 | 99265 | 102772 | 102804 | 102821 | 102844 | 102888 | 102910 | 102911 | 102912