Attachment 102932 Details for Bug 24697 – Bug 24697: Split items.uri on staff detail view

[patch] Bug 24697: Split items.uri on staff detail view

Bug-24697-Split-itemsuri-on-staff-detail-view.patch (text/plain), 2.82 KB, created by Jonathan Druart on 2020-04-14 14:01:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-04-14 14:01:07 UTC

Size: 2.82 KB

patch

obsolete

>From be61becdf02e0ff6bed9ef9fadcbe1f311986bac Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 20 Feb 2020 12:10:57 +0000
>Subject: [PATCH] Bug 24697: Split items.uri on staff detail view
>
>If there are more URIs, we split on vertical bar and show the real URL
>instead of duplicated text. Otherwise display depends on the pref
>URLLinkText.
>
>Test plan:
>Create item with uri = A | B | C
>Create another item with uri = D
>Check the results on staff detail view (items table).
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Works as described, no errors.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../prog/en/modules/catalogue/detail.tt            | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index 6ef518489b..5617968f6f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -402,12 +402,16 @@ Note that permanent location is a code, and location may be an authval.
>                     <td class="dateaccessioned"><span title="[% item.dateaccessioned | html %]">[% item.dateaccessioned | $KohaDates %]</span></td>
>                     <td><a href="/cgi-bin/koha/catalogue/moredetail.pl?type=[% item.type | uri %]&amp;itemnumber=[% item.itemnumber | uri %]&amp;biblionumber=[% item.biblionumber | uri %]&amp;bi=[% item.biblioitemnumber | uri %]#item[% item.itemnumber | uri %]">[% item.barcode | html %]</a></td>
>                     [% IF ( itemdata_uri ) %]
>-                        [% IF Koha.Preference('URLLinkText') %]
>-                            <td class="uri"><a href="[% item.uri | url %]">[% Koha.Preference('URLLinkText') | html %]</a></td>
>-                        [% ELSIF item.uri %]
>-                            <td class="uri"><a href="[% item.uri | url %]">Link to resource</a></td>
>+                        [% IF item.uri.split(' \| ').size > 1 %]
>+                            <td class="uri">
>+                                [% FOREACH uri IN item.uri.split(' \| ') %]<a href="[% uri | url %]">[% uri | html %]</a><br>[% END %]
>+                            </td>
>                         [% ELSE %]
>-                            <td></td>
>+                            <td class="uri">
>+                                [% IF item.uri %]
>+                                    <a href="[% item.uri | url %]">[% IF Koha.Preference('URLLinkText') %][% Koha.Preference('URLLinkText') | html %][% ELSE %]Link to resource[% END %]</a>
>+                                [% END %]
>+                            </td>
>                         [% END %]
>                     [% END %]
>                     [% IF ( itemdata_copynumber ) %]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24697: 99308 | 99354 | 99467 | 102932