Attachment 103045 Details for Bug 17853 – Bug 17853: Don't remove () from 785 link text and restore link value of 780

[patch] Bug 17853: Don't remove () from 785 link text and restore link value of 780

Bug-17853-Dont-remove--from-785-link-text-and-rest.patch (text/plain), 5.50 KB, created by Katrin Fischer on 2020-04-15 23:47:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-04-15 23:47:15 UTC

Size: 5.50 KB

patch

obsolete

>From 479328d9c6d837681487efe2dd168d6a220760b7 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sun, 12 Apr 2020 22:34:21 +0000
>Subject: [PATCH] Bug 17853: Don't remove () from 785 link text and restore
> link value of 780
>
>The only thing we change for 780 and 785 is, that if the display
>text contains (), they are no longer removed.
>
>To test:
>- Catalogue a record with 785$a some text (including) parenthesis
>    e.g. Hospitals (Chicago, Ill. : 1936)
>- Verify that the () are not shown in the link text and are not part of the URL.
>- Apply patch
>- Verify that the () are shown in the link text and are not part of the URL.
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl      | 8 ++++----
> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl   | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>index cadf826c13..506e41afbd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>@@ -1228,12 +1228,12 @@
>             <xsl:choose>
>                 <xsl:when test="$UseControlNumber = '1' and marc:subfield[@code='w']">
>                     <a><xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=Control-number:<xsl:call-template name="extractControlNumber"><xsl:with-param name="subfieldW" select="marc:subfield[@code='w']"/></xsl:call-template></xsl:attribute>
>-                        <xsl:value-of select="marc:subfield[@code='a']"/>
>+                        <xsl:value-of select="$f780"/>
>                     </a>
>                 </xsl:when>
>                 <xsl:otherwise>
>                     <a><xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=ti,phr:<xsl:value-of select="str:encode-uri(translate($f780, '()', ''), true())"/></xsl:attribute>
>-                        <xsl:value-of select="marc:subfield[@code='a']"/>
>+                        <xsl:value-of select="$f780"/>
>                     </a>
>                 </xsl:otherwise>
>             </xsl:choose>
>@@ -1290,12 +1290,12 @@
>             <xsl:choose>
>                 <xsl:when test="$UseControlNumber = '1' and marc:subfield[@code='w']">
>                     <a><xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=Control-number:<xsl:call-template name="extractControlNumber"><xsl:with-param name="subfieldW" select="marc:subfield[@code='w']"/></xsl:call-template></xsl:attribute>
>-                        <xsl:value-of select="translate($f785, '()', '')"/>
>+                        <xsl:value-of select="$f785"/>
>                     </a>
>                 </xsl:when>
>                 <xsl:otherwise>
>                     <a><xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=ti,phr:<xsl:value-of select="str:encode-uri(translate($f785, '()', ''), true())"/></xsl:attribute>
>-                        <xsl:value-of select="translate($f785, '()', '')"/>
>+                        <xsl:value-of select="$f785"/>
>                     </a>
>                 </xsl:otherwise>
>             </xsl:choose>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>index 8fe98a0b29..dbda243cf0 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>@@ -1340,12 +1340,12 @@
>             <xsl:choose>
>                 <xsl:when test="$UseControlNumber = '1' and marc:subfield[@code='w']">
>                     <a><xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=Control-number:<xsl:call-template name="extractControlNumber"><xsl:with-param name="subfieldW" select="marc:subfield[@code='w']"/></xsl:call-template></xsl:attribute>
>-                        <xsl:value-of select="marc:subfield[@code='a']"/>
>+                        <xsl:value-of select="$f780"/>
>                     </a>
>                 </xsl:when>
>                 <xsl:otherwise>
>                     <a><xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=ti,phr:<xsl:value-of select="str:encode-uri(translate($f780, '()', ''), true())"/></xsl:attribute>
>-                        <xsl:value-of select="marc:subfield[@code='a']"/>
>+                        <xsl:value-of select="$f780"/>
>                     </a>
>                 </xsl:otherwise>
>             </xsl:choose>
>@@ -1403,12 +1403,12 @@
>             <xsl:choose>
>                 <xsl:when test="$UseControlNumber = '1' and marc:subfield[@code='w']">
>                     <a><xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=Control-number:<xsl:call-template name="extractControlNumber"><xsl:with-param name="subfieldW" select="marc:subfield[@code='w']"/></xsl:call-template></xsl:attribute>
>-                        <xsl:value-of select="translate($f785, '()', '')"/>
>+                        <xsl:value-of select="$f785"/>
>                     </a>
>                 </xsl:when>
>                 <xsl:otherwise>
>                     <a><xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=ti,phr:<xsl:value-of select="str:encode-uri(translate($f785, '()', ''), true())"/></xsl:attribute>
>-                        <xsl:value-of select="translate($f785, '()', '')"/>
>+                        <xsl:value-of select="$f785"/>
>                     </a>
>                 </xsl:otherwise>
>             </xsl:choose>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 17853: 59190 | 59198 | 61877 | 62078 | 62079 | 63325 | 63326 | 103044 | 103045 | 103219 | 103220 | 104573