Bugzilla – Attachment 103107 Details for
Bug 24487
build_query_params helper builds path parameter with matching criteria
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[19.11.x] Bug 24487: Add 2 more tests
1911x-Bug-24487-Add-2-more-tests.patch (text/plain), 3.14 KB, created by
Tomás Cohen Arazi (tcohen)
on 2020-04-16 21:54:27 UTC
(
hide
)
Description:
[19.11.x] Bug 24487: Add 2 more tests
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2020-04-16 21:54:27 UTC
Size:
3.14 KB
patch
obsolete
>From 05a3ab53376bd63e4b10432762abf520c238236b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 23 Jan 2020 10:47:17 +0100 >Subject: [PATCH] [19.11.x] Bug 24487: Add 2 more tests > >And make sure tests pass if there is no patron with borrowernumber=10 in >DB. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Ammended test description >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/Koha/REST/Plugin/Objects.t | 31 +++++++++++++++++++---- > 1 file changed, 26 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/Koha/REST/Plugin/Objects.t b/t/db_dependent/Koha/REST/Plugin/Objects.t >index 3575bbbdcc..63e2123725 100644 >--- a/t/db_dependent/Koha/REST/Plugin/Objects.t >+++ b/t/db_dependent/Koha/REST/Plugin/Objects.t >@@ -65,10 +65,16 @@ get '/patrons/:patron_id/holds' => sub { > $params->{patron_id} = $c->stash("patron_id"); > $c->validation->output($params); > my $holds_set = Koha::Holds->new; >- my $holds = $c->objects->search( $holds_set ); >+ my $holds = $c->objects->search( $holds_set, \&to_model_holds ); > $c->render( status => 200, json => {count => scalar(@$holds)} ); > }; > >+sub to_model_holds { >+ my ($params) = @_; >+ $params->{borrowernumber} = delete $params->{patron_id}; >+ return $params; >+} >+ > sub to_model { > my $params = shift; > >@@ -99,12 +105,12 @@ use Koha::Database; > my $schema = Koha::Database->new->schema; > my $builder = t::lib::TestBuilder->new; > >+my $t = Test::Mojo->new; >+ > subtest 'objects.search helper' => sub { > > plan tests => 90; > >- my $t = Test::Mojo->new; >- > $schema->storage->txn_begin; > > # Remove existing cities to have more control on the search restuls >@@ -285,13 +291,22 @@ subtest 'objects.search helper, sorting on mapped column' => sub { > }; > > subtest 'objects.search helper, with path parameters and _match' => sub { >- plan tests => 4; >+ plan tests => 8; > > $schema->storage->txn_begin; > > Koha::Holds->search()->delete; > >- $builder->build_object({class=>"Koha::Holds", value => {borrowernumber => 10 }}); >+ my $patron = Koha::Patrons->find(10); >+ $patron->delete if $patron; >+ $patron = $builder->build_object( { class => "Koha::Patrons" } ); >+ $patron->borrowernumber(10)->store; >+ $builder->build_object( >+ { >+ class => "Koha::Holds", >+ value => { borrowernumber => $patron->borrowernumber } >+ } >+ ); > > $t->get_ok('/patrons/1/holds?_match=exact') > ->json_is('/count' => 0, 'there should be no holds for borrower 1 with _match=exact'); >@@ -299,5 +314,11 @@ subtest 'objects.search helper, with path parameters and _match' => sub { > $t->get_ok('/patrons/1/holds?_match=contains') > ->json_is('/count' => 0, 'there should be no holds for borrower 1 with _match=contains'); > >+ $t->get_ok('/patrons/10/holds?_match=exact') >+ ->json_is('/count' => 1, 'there should be 1 hold for borrower 10 with _match=exact'); >+ >+ $t->get_ok('/patrons/10/holds?_match=contains') >+ ->json_is('/count' => 1, 'there should be 1 hold for borrower 10 with _match=contains'); >+ > $schema->storage->txn_rollback; > }; >-- >2.26.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24487
:
97765
|
97772
|
97774
|
97775
|
97782
|
98029
|
98030
|
98031
|
98164
|
98165
|
98166
|
103105
|
103106
|
103107
|
103142
|
103143
|
103144