Bugzilla – Attachment 103116 Details for
Bug 25147
AllowSelfCheckReturns is in the wrong system preference section
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25147: Rename preference
Bug-25147-Rename-preference.patch (text/plain), 3.50 KB, created by
Martin Renvoize (ashimema)
on 2020-04-17 07:21:13 UTC
(
hide
)
Description:
Bug 25147: Rename preference
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-04-17 07:21:13 UTC
Size:
3.50 KB
patch
obsolete
>From 0ee79da5c508dce44eae7f42b71f2676bc38433d Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 17 Apr 2020 08:16:10 +0100 >Subject: [PATCH] Bug 25147: Rename preference > >This patch renames the preference from the ambiguous 'AllowSelfCheckReturns' >to 'SCOAllowCheckin' which is more consistent with other preferences >affecting this module. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > installer/data/mysql/atomicupdate/bug_25147.perl | 7 +++++++ > installer/data/mysql/sysprefs.sql | 2 +- > 2 files changed, 8 insertions(+), 1 deletion(-) > create mode 100644 installer/data/mysql/atomicupdate/bug_25147.perl > >diff --git a/installer/data/mysql/atomicupdate/bug_25147.perl b/installer/data/mysql/atomicupdate/bug_25147.perl >new file mode 100644 >index 0000000000..9be719a6ab >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_25147.perl >@@ -0,0 +1,7 @@ >+$DBversion = 'XXX'; # will be replaced by the RM >+if( CheckVersion( $DBversion ) ) { >+ $dbh->do( "UPDATE systempreferences SET variable = 'SCOAllowCheckin' WHERE variable = 'AllowSelfCheckReturns'" ); >+ >+ # Always end with this (adjust the bug info) >+ NewVersion( $DBversion, 25147, "Rename AllowSelfCheckReturns to SCOAllowCheckin for consistency"); >+} >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 2c5b01fba8..c9aa5d9ff5 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -43,7 +43,6 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('AllowRenewalLimitOverride','0',NULL,'if ON, allows renewal limits to be overridden on the circulation screen','YesNo'), > ('AllowRenewalOnHoldOverride','0',NULL,'If ON, allow items on hold to be renewed with a specified due date','YesNo'), > ('AllowReturnToBranch','anywhere','anywhere|homebranch|holdingbranch|homeorholdingbranch','Where an item may be returned','Choice'), >-('AllowSelfCheckReturns','0','','If enabled, patrons may return items through the Web-based Self Checkout','YesNo'), > ('AllowStaffToSetCheckoutsVisibilityForGuarantor','0',NULL,'If enabled, library staff can set a patron''s checkouts to be visible to linked patrons from the opac.', 'YesNo'), > ('AllowStaffToSetFinesVisibilityForGuarantor','0',NULL,'If enabled, library staff can set a patron''s fines to be visible to linked patrons from the opac.', 'YesNo'), > ('AllowTooManyOverride','1','','If on, allow staff to override and check out items when the patron has reached the maximum number of allowed checkouts','YesNo'), >@@ -557,6 +556,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('RoutingListAddReserves','0','','If ON the patrons on routing lists are automatically added to holds on the issue.','YesNo'), > ('RoutingListNote','To change this note edit <a href=\"/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=RoutingListNote#jumped\">RoutingListNote</a> system preference.','70|10','Define a note to be shown on all routing lists','Textarea'), > ('RoutingSerials','1',NULL,'If ON, serials routing is enabled','YesNo'), >+('SCOAllowCheckin','0','','If enabled, patrons may return items through the Web-based Self Checkout','YesNo'), > ('SCOMainUserBlock','','70|10','Add a block of HTML that will display on the self checkout screen','Textarea'), > ('SCOUserCSS','',NULL,'Add CSS to be included in the SCO module in an embedded <style> tag.','free'), > ('SCOUserJS','',NULL,'Define custom javascript for inclusion in the SCO module','free'), >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25147
:
103022
|
103059
|
103069
| 103116 |
103117
|
103120
|
103121