Bugzilla – Attachment 103125 Details for
Bug 21901
Foreign keys are missing on the serials and subscriptions tables
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21901: (QA follow-up) Add a few NOT NULL constraints in dbrev
Bug-21901-QA-follow-up-Add-a-few-NOT-NULL-constrai.patch (text/plain), 1.46 KB, created by
Marcel de Rooy
on 2020-04-17 08:17:52 UTC
(
hide
)
Description:
Bug 21901: (QA follow-up) Add a few NOT NULL constraints in dbrev
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2020-04-17 08:17:52 UTC
Size:
1.46 KB
patch
obsolete
>From bbbf600bbdea2e95ca924a8749c54dbb1fc495a4 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 17 Apr 2020 08:04:14 +0000 >Subject: [PATCH] Bug 21901: (QA follow-up) Add a few NOT NULL constraints in > dbrev >Content-Type: text/plain; charset=utf-8 > >We need to specify NOT NULL on subscription and -history as well. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > installer/data/mysql/atomicupdate/bug_21901.perl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_21901.perl b/installer/data/mysql/atomicupdate/bug_21901.perl >index e319f71a81..fb11d77bdd 100644 >--- a/installer/data/mysql/atomicupdate/bug_21901.perl >+++ b/installer/data/mysql/atomicupdate/bug_21901.perl >@@ -72,8 +72,8 @@ if( CheckVersion( $DBversion ) ) { > > $dbh->do(q| > ALTER TABLE subscriptionhistory >- MODIFY COLUMN biblionumber int(11), >- MODIFY COLUMN subscriptionid int(11) >+ MODIFY COLUMN biblionumber int(11) NOT NULL, >+ MODIFY COLUMN subscriptionid int(11) NOT NULL > |); > > unless ( foreign_key_exists( 'subscriptionhistory', 'subscription_history_ibfk_1' ) ) { >@@ -98,7 +98,7 @@ if( CheckVersion( $DBversion ) ) { > > $dbh->do(q| > ALTER TABLE subscription >- MODIFY COLUMN biblionumber int(11) >+ MODIFY COLUMN biblionumber int(11) NOT NULL > |); > > unless ( foreign_key_exists( 'subscription', 'subscription_ibfk_3' ) ) { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21901
:
96181
|
98177
|
98229
|
98231
|
100384
|
100545
|
100546
|
100547
|
103122
|
103123
|
103124
| 103125 |
103151