Attachment 103184 Details for Bug 15969 – Bug 15969 - Fetch the message instead of substituting

[patch] Bug 15969 - Fetch the message instead of substituting

Bug-15969---Fetch-the-message-instead-of-substitut.patch (text/plain), 1.91 KB, created by Kyle M Hall (khall) on 2020-04-17 18:58:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-04-17 18:58:04 UTC

Size: 1.91 KB

patch

obsolete

>From ca349b893bea6d66e65bbbecccbb86cc9de57f24 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 2 Dec 2016 16:22:02 +0000
>Subject: [PATCH] Bug 15969 - Fetch the message instead of substituting
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> C4/Letters.pm                                          | 2 +-
> misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/C4/Letters.pm b/C4/Letters.pm
>index 6df80a9cd1..380a478596 100644
>--- a/C4/Letters.pm
>+++ b/C4/Letters.pm
>@@ -47,7 +47,7 @@ BEGIN {
>     require Exporter;
>     @ISA = qw(Exporter);
>     @EXPORT = qw(
>-        &GetLetters &GetLettersAvailableForALibrary &GetLetterTemplates &DelLetter &GetPreparedLetter &GetWrappedLetter &SendAlerts &GetPrintMessages &GetMessageTransportTypes
>+        &GetLetters &GetLettersAvailableForALibrary &GetLetterTemplates &DelLetter &GetPreparedLetter &GetWrappedLetter &SendAlerts &GetPrintMessages &GetMessageTransportTypes &GetMessage
>     );
> }
> 
>diff --git a/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl b/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
>index fcf331099f..ea7c8f49e8 100755
>--- a/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
>+++ b/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
>@@ -174,8 +174,8 @@ foreach my $type (@types) {
>         }
> 
>         if ( $use_tt ) {
>-            $letter->{content} =~ s/__MESSAGE_ID__/$message_id/g;
>-            print $OUT $letter->{content};
>+            my $message = GetMessage( $message_id );
>+            print $OUT $message->{content};
>         } else {
>             print $OUT "\"$format\",\"$language\",\"$type\",\"$issues->{level}\",\"$issues->{cardnumber}\",\"$issues->{patron_title}\",\"$issues->{firstname}\",";
>             print $OUT "\"$issues->{surname}\",\"$issues->{phone}\",\"$issues->{email}\",\"$library_code\",";
>-- 
>2.24.2 (Apple Git-127)

Actions: View | Diff | Splinter Review

Attachments on bug 15969: 48618 | 48811 | 55819 | 55820 | 57931 | 57933 | 57934 | 57935 | 59923 | 59924 | 59925 | 59926 | 59937 | 59940 | 59941 | 59942 | 59943 | 59944 | 59945 | 59962 | 59963 | 59964 | 59965 | 71141 | 71142 | 71143 | 71144 | 103181 | 103182 | 103183 | 103184 | 114413 | 114414 | 114415 | 114416 | 118207 | 118208 | 118209 | 118210