Attachment 10328 Details for Bug 8194 – [SIGNED-OFF] Bug 8194 - Layout problem on subscription add when showing manual history

[patch] [SIGNED-OFF] Bug 8194 - Layout problem on subscription add when showing manual history

SIGNED-OFF-Bug-8194---Layout-problem-on-subscripti.patch (text/plain), 2.54 KB, created by Katrin Fischer on 2012-06-17 08:05:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2012-06-17 08:05:29 UTC

Size: 2.54 KB

patch

obsolete

>From e2925dde2751fe8a75761437368e589a9f49b7dd Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 15 Jun 2012 10:36:33 -0400
>Subject: [PATCH] [SIGNED-OFF] Bug 8194 - Layout problem on subscription add
> when showing manual history
>
>Markup errors were causing display problems when the "manual history"
>section is shown.
>
>To test, apply the patch, load the subscription add page, and check
>the "manual history" checkbox. The "Serials planning" section
>should appear directly below the "manual history" section.
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Works nicely.
>---
> .../prog/en/modules/serials/subscription-add.tt    |    9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>index d72a20f..224cad6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>@@ -1083,8 +1083,8 @@ $(document).ready(function() {
> 	</fieldset>
> 	</div>
> 	
>-<div id="subscription_form_history" class="yui-u" style="display:none">
>-<div><h3 style="display:inline">Subscription history</h3> <a href="#" id="cancel_manual_history">[cancel manual history]</a></div>
>+<div class="yui-u">
>+<div id="subscription_form_history" style="display:none"><h3 style="display:inline">Subscription history</h3> <a href="#" id="cancel_manual_history">[cancel manual history]</a>
>         <p>Hint: you can update the serial history manually. This can be useful for an old subscription or to clean the existing history. Modify these fields with care, as future serial receive will continue to update them automatically.</p>
>         <fieldset class="rows">
>             <ol>
>@@ -1117,7 +1117,6 @@ $(document).ready(function() {
>     <fieldset class="action"><input type="submit" value="Save subscription history"  /></fieldset>
> </div>
> 
>-<div class="yui-g">
> <div id="subscription_form_planning">
> 	<fieldset class="rows">
> 	<legend>Serials planning</legend>
>@@ -1371,7 +1370,7 @@ $(document).ready(function() {
>     </li>
>     </ol>
> 	</fieldset>
>-</div>
>+
> 	<fieldset class="action">
>     <input type="button" class="action_test" value="Test prediction pattern" onclick="javascript:irregularity_check()" />
>     <input type="button" class="action_reset" value="Reset pattern" onclick="javascript:reset_pattern()" />
>@@ -1441,7 +1440,7 @@ $(document).ready(function() {
>         </div>
> 
> </div>
>-
>+</div>
> </form>
> </div>
> 
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 8194: 10252 | 10255 | 10298 | 10328