Attachment 103295 Details for Bug 25123 – Bug 25123: Count the current fine when reducing for maxFine

[patch] Bug 25123: Count the current fine when reducing for maxFine

Bug-25123-Count-the-current-fine-when-reducing-for.patch (text/plain), 1.47 KB, created by Jonathan Druart on 2020-04-20 13:06:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-04-20 13:06:05 UTC

Size: 1.47 KB

patch

obsolete

>From 318a7ac09574d3a50c859ef9f6240cb1031b414d Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 13 Apr 2020 11:38:28 +0000
>Subject: [PATCH] Bug 25123: Count the current fine when reducing for maxFine
>
>If maxFine is set, we total the patrons outstanding fines when making an adjustment, however, we neglect to count the amount of a currently updating fine when doing so.
>
>To test:
>1 - Set maxFine to 5
>2 - Create an overdue amount of 4.99 for a patron
>3 - Set an itemtype to have a fine of $.10 per day
>4 - Checkout an item of that type to a patron and backdate the due date so it is overdue
>5 - Run fines.pl with -v
>6 - Note the fine is reduced from $.10 (or a multiple) to .01
>7 - Run it again, a second cent is added
>8 - Repeat and note it keeps happening until the amount of the fine is reached, exceeding the maxFine setting
>9 - Apply patch
>10 - Note the fine is now reduced to 0 and nothing is added to account
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> C4/Overdues.pm | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/C4/Overdues.pm b/C4/Overdues.pm
>index 2f1212ba0c..b6773c2cf1 100644
>--- a/C4/Overdues.pm
>+++ b/C4/Overdues.pm
>@@ -552,7 +552,6 @@ sub UpdateFine {
>             }
>             else {
>                 $accountline = $overdue;
>-                next;
>             }
>         }
>         $total_amount_other += $overdue->amountoutstanding;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25123: 102812 | 102813 | 102920 | 103232 | 103233 | 103234 | 103294 | 103295 | 103296