Attachment 103296 Details for Bug 25123 – Bug 25123: (QA follow-up) Re-used variable name

[patch] Bug 25123: (QA follow-up) Re-used variable name

Bug-25123-QA-follow-up-Re-used-variable-name.patch (text/plain), 1.17 KB, created by Jonathan Druart on 2020-04-20 13:06:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-04-20 13:06:08 UTC

Size: 1.17 KB

patch

obsolete

>From 67f35746f05abb514203bb2be94fc56091b05a93 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Mon, 20 Apr 2020 08:37:10 +0100
>Subject: [PATCH] Bug 25123: (QA follow-up) Re-used variable name
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> t/db_dependent/Overdues.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Overdues.t b/t/db_dependent/Overdues.t
>index 5305066f84..4981071a51 100644
>--- a/t/db_dependent/Overdues.t
>+++ b/t/db_dependent/Overdues.t
>@@ -262,7 +262,7 @@ subtest 'UpdateFine tests' => sub {
>     $fine = $fines->next;
>     is( $fine->amount+0, 80, "First fine amount unchanged" );
>     is( $fine->amountoutstanding+0, 80, "First fine amountoutstanding unchanged" );
>-    my $fine2 = $fines->next;
>+    $fine2 = $fines->next;
>     is( $fine2->amount+0, 20, "Second fine capped at '20' by MaxFine" );
>     is( $fine2->amountoutstanding+0, 20, "Second fine amountoutstanding capped at '20' by MaxFine" );
>     is( $fine2->issue_id, $checkout2->issue_id, "Second fine is associated with the correct issue" );
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25123: 102812 | 102813 | 102920 | 103232 | 103233 | 103234 | 103294 | 103295 | 103296