Attachment 103343 Details for Bug 25089 – Bug 25089: Sort circulation rules

[patch] Bug 25089: Sort circulation rules

Bug-25089-Sort-circulation-rules.patch (text/plain), 2.95 KB, created by Lari Taskula on 2020-04-21 10:28:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lari Taskula

Created: 2020-04-21 10:28:02 UTC

Size: 2.95 KB

patch

obsolete

>From 3ce7baf2c5e6bc3e378f043cdd7520addbafc38b Mon Sep 17 00:00:00 2001
>From: Lari Taskula <lari.taskula@hypernova.fi>
>Date: Tue, 31 Mar 2020 16:27:39 +0000
>Subject: [PATCH] Bug 25089: Sort circulation rules
>
>Sponsored-by: The National Library of Finland
>---
> Koha/CirculationRules.pm | 38 ++++++++++++++++++++------------------
> 1 file changed, 20 insertions(+), 18 deletions(-)
>
>diff --git a/Koha/CirculationRules.pm b/Koha/CirculationRules.pm
>index c267930bda..546d72fa56 100644
>--- a/Koha/CirculationRules.pm
>+++ b/Koha/CirculationRules.pm
>@@ -50,9 +50,6 @@ our $RULE_KINDS = {
>         scope => [ 'branchcode' ],
>     },
> 
>-    patron_maxissueqty => {
>-        scope => [ 'branchcode', 'categorycode', 'checkout_type' ],
>-    },
>     max_holds => {
>         scope => [ 'branchcode', 'categorycode' ],
>     },
>@@ -67,9 +64,29 @@ our $RULE_KINDS = {
>         scope => [ 'branchcode', 'itemtype' ],
>     },
> 
>+    patron_maxissueqty => {
>+        scope => [ 'branchcode', 'categorycode', 'checkout_type' ],
>+    },
>+
>     article_requests => {
>         scope => [ 'branchcode', 'categorycode', 'itemtype' ],
>     },
>+    holds_per_day => {
>+        scope => [ 'branchcode', 'categorycode', 'itemtype' ],
>+    },
>+    holds_per_record => {
>+        scope => [ 'branchcode', 'categorycode', 'itemtype' ],
>+    },
>+    onshelfholds => {
>+        scope => [ 'branchcode', 'categorycode', 'itemtype' ],
>+    },
>+    opacitemholds => {
>+        scope => [ 'branchcode', 'categorycode', 'itemtype' ],
>+    },
>+    reservesallowed => {
>+        scope => [ 'branchcode', 'categorycode', 'itemtype' ],
>+    },
>+
>     auto_renew => {
>         scope => [ 'branchcode', 'categorycode', 'itemtype', 'checkout_type' ],
>     },
>@@ -97,12 +114,6 @@ our $RULE_KINDS = {
>     hardduedatecompare => {
>         scope => [ 'branchcode', 'categorycode', 'itemtype', 'checkout_type' ],
>     },
>-    holds_per_day => {
>-        scope => [ 'branchcode', 'categorycode', 'itemtype' ],
>-    },
>-    holds_per_record => {
>-        scope => [ 'branchcode', 'categorycode', 'itemtype' ],
>-    },
>     issuelength => {
>         scope => [ 'branchcode', 'categorycode', 'itemtype', 'checkout_type' ],
>     },
>@@ -124,12 +135,6 @@ our $RULE_KINDS = {
>     norenewalbefore => {
>         scope => [ 'branchcode', 'categorycode', 'itemtype', 'checkout_type' ],
>     },
>-    onshelfholds => {
>-        scope => [ 'branchcode', 'categorycode', 'itemtype' ],
>-    },
>-    opacitemholds => {
>-        scope => [ 'branchcode', 'categorycode', 'itemtype' ],
>-    },
>     overduefinescap => {
>         scope => [ 'branchcode', 'categorycode', 'itemtype', 'checkout_type' ],
>     },
>@@ -142,9 +147,6 @@ our $RULE_KINDS = {
>     rentaldiscount => {
>         scope => [ 'branchcode', 'categorycode', 'itemtype', 'checkout_type' ],
>     },
>-    reservesallowed => {
>-        scope => [ 'branchcode', 'categorycode', 'itemtype' ],
>-    },
>     suspension_chargeperiod => {
>         scope => [ 'branchcode', 'categorycode', 'itemtype', 'checkout_type' ],
>     },
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 25089: 103046 | 103047 | 103048 | 103049 | 103050 | 103051 | 103052 | 103053 | 103054 | 103239 | 103240 | 103241 | 103242 | 103243 | 103244 | 103245 | 103246 | 103247 | 103248 | 103283 | 103284 | 103285 | 103286 | 103287 | 103288 | 103289 | 103290 | 103291 | 103292 | 103339 | 103340 | 103341 | 103342 | 103343 | 103344 | 103345 | 103346 | 103347 | 103348 | 103349 | 103351 | 103352 | 103353 | 103354 | 103355 | 103356 | 103357 | 103358 | 103359 | 103360 | 103361 | 103537 | 103538 | 103539 | 103540 | 103541 | 103542 | 103543 | 103544 | 103545 | 103546 | 103547 | 104274 | 104275 | 107523 | 107524 | 107525 | 107526 | 107527 | 107528 | 107529 | 107530 | 107531 | 107532 | 107533