Bugzilla – Attachment 103390 Details for
Bug 25186
Lots of white space at the bottom of each tab on columns configuration
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25186: Fix accordion sections height in columns configuration page
Bug-25186-Fix-accordion-sections-height-in-columns.patch (text/plain), 1.56 KB, created by
Josef Moravec
on 2020-04-21 15:52:35 UTC
(
hide
)
Description:
Bug 25186: Fix accordion sections height in columns configuration page
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2020-04-21 15:52:35 UTC
Size:
1.56 KB
patch
obsolete
>From 4b830dc8149d87f04557ba103e1c14d85c2f3951 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 20 Apr 2020 11:13:40 +0200 >Subject: [PATCH] Bug 25186: Fix accordion sections height in columns > configuration page > >The height for each section was the height of the highest section. >Now the height is set to the length of the section. > >Test plan: >Go to Administration > Column configuration >Open the sections and confirm that the height fits its content. > >QA: note that I guess "autoHeight: false" was meant to acchieve that, >but it does not exist in the API of the plugin. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt >index d88804a263..db421ced84 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt >@@ -226,7 +226,7 @@ > $(document).ready( function() { > var accordion = $( "#modules" ).accordion({ > collapsible: true, >- autoHeight: false, >+ heightStyle: "content", > header: ".panel_header", > [%- IF panel -%] > [%# we were asked to show a specific panel, usually on update %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25186
:
103237
|
103279
| 103390