Attachment 10347 Details for Bug 6939 – Proposed Patch

[patch] Proposed Patch

0001-Bug-6939-DefaultClassificationSource-should-be-defau.patch (text/plain), 1.23 KB, created by Colin Campbell on 2012-06-18 10:32:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Colin Campbell

Created: 2012-06-18 10:32:24 UTC

Size: 1.23 KB

patch

obsolete

>From f93e3165d0714bca542eff25c2187f5b4e20cabd Mon Sep 17 00:00:00 2001
>From: Colin Campbell <colin.campbell@ptfs-europe.com>
>Date: Mon, 18 Jun 2012 11:23:42 +0100
>Subject: [PATCH] Bug 6939 DefaultClassificationSource should be default in
> 942
>
>A logic bug in the original code adding DefaultClassificationSource
>caused the default not to be used (the last used value was used instead)
>The bug was fixed in additem by bug 2398 but addbiblio's use
>of the code was not fixed.
>---
> cataloguing/addbiblio.pl | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl
>index d5778a4..d9edf7a 100755
>--- a/cataloguing/addbiblio.pl
>+++ b/cataloguing/addbiblio.pl
>@@ -215,10 +215,8 @@ sub build_authorized_values_list {
>                         ($class_source eq $default_source);
>             push @authorised_values, $class_source;
>             $authorised_lib{$class_source} = $class_sources->{$class_source}->{'description'};
>-            $value = $class_source unless ($value);
>-            $value = $default_source unless ($value);
>         }
>-        #---- "true" authorised value
>+        $value = $default_source unless $value;
>     }
>     else {
>         $authorised_values_sth->execute(
>-- 
>1.7.11
>

Actions: View | Diff | Splinter Review

Attachments on bug 6939: 10347 | 10414