Bugzilla – Attachment 103472 Details for
Bug 25235
Don't alert when replacing an authority record via Z39.50
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25235: Rename the button instead of alerting when replacing an existing record
Bug-25235-Rename-the-button-instead-of-alerting-wh.patch (text/plain), 3.52 KB, created by
Owen Leonard
on 2020-04-22 12:55:49 UTC
(
hide
)
Description:
Bug 25235: Rename the button instead of alerting when replacing an existing record
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2020-04-22 12:55:49 UTC
Size:
3.52 KB
patch
obsolete
>From 8799d669f8178950f4578aaf4492b3f6db13ab97 Mon Sep 17 00:00:00 2001 >From: Phil Ringnalda <phil@chetcolibrary.org> >Date: Tue, 21 Apr 2020 21:34:33 -0700 >Subject: [PATCH] Bug 25235: Rename the button instead of alerting when > replacing an existing record > >Test plan: > >Pre-patch >1 - Go to the main Authorities page, search for any authority, click > the Actions menubutton and choose Edit >2 - Note the button saying Z39.50 search >3 - Note the modal alert forcing you to click it >4 - Cancel and cancel again, and in the New authority menubutton choose > Default >5 - Click the button saying Z39.50 search again, note that it warns you > about replacing your totally blank record > >Apply this patch >6 - Edit an existing authority, note the button says "Replace record via > Z39.50/SRU search" >2 - Click the button, verify it still opens the search window with the > main entry of the record filled in without an alert >3 - Create a new authority, note the button says "Z39.50/SRU search" >4 - Click the button, verify it still opens the search window but > without an alert > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../prog/en/modules/authorities/authorities.tt | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >index 76c1df8ceb..026f48560f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >@@ -12,7 +12,7 @@ > $("#loading").hide(); > }); > var Sticky; >- $(document).ready(function() { >+ $(document).ready(function() { > var tabs = $('#authoritytabs').tabs(); > $( "ul.sortable_field", tabs ).sortable(); > $( "ul.sortable_subfield", tabs ).sortable(); >@@ -27,15 +27,13 @@ > } > }); > $("#z3950submit").click(function(){ >- if (confirm(_("Please note that this Z39.50 search could replace the current record."))){ >- var strQuery = GetZ3950Terms(); >- if(strQuery){ >- window.open("/cgi-bin/koha/cataloguing/z3950_auth_search.pl?authid=[% authid | html %]"+strQuery,"z3950search",'width=740,height=450,location=yes,toolbar=no,scrollbars=yes,resize=yes'); >- } >+ var strQuery = GetZ3950Terms(); >+ if(strQuery){ >+ window.open("/cgi-bin/koha/cataloguing/z3950_auth_search.pl?authid=[% authid | html %]"+strQuery,"z3950search",'width=740,height=450,location=yes,toolbar=no,scrollbars=yes,resize=yes'); > } > return false; > }); >- }); >+ }); > > /** > * check if z3950 mandatories are set or not >@@ -217,7 +215,11 @@ function confirmnotdup(redirect){ > <div id="toolbar" class="btn-toolbar"> > <div class="btn-group"><a href="#" id="addauth" class="btn btn-default" accesskey="w"><i class="fa fa-save"></i> Save</a></div> > <div class="btn-group"> >- <a class="btn btn-default" id="z3950submit" href="#"><i class="fa fa-search"></i> Z39.50 search</a> >+ [% IF ( authid ) %] >+ <a class="btn btn-default" id="z3950submit" href="#"><i class="fa fa-search"></i> Replace record via Z39.50/SRU search</a> >+ [% ELSE %] >+ <a class="btn btn-default" id="z3950submit" href="#"><i class="fa fa-search"></i> Z39.50/SRU search</a> >+ [% END %] > </div> > <div class="btn-group"> > [% IF ( authid ) %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25235
:
103439
|
103472
|
103473
|
103476