Attachment 103475 Details for Bug 25231 – Bug 25231: Rename button instead of alert/confirm when replacing record

[patch] Bug 25231: Rename button instead of alert/confirm when replacing record

Bug-25231-Rename-button-instead-of-alertconfirm-wh.patch (text/plain), 2.65 KB, created by Jonathan Druart on 2020-04-22 13:27:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-04-22 13:27:59 UTC

Size: 2.65 KB

patch

obsolete

>From 81b8974dcfaa472ab04fb58d1f41b0ac387c08a5 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 21 Apr 2020 17:30:00 +0000
>Subject: [PATCH] Bug 25231: Rename button instead of alert/confirm when
> replacing record
>
>This test plan applies to the basic editor only
>
>To test:
>1 - Edit an existing record
>2 - Click 'Z3950 Search'
>3 - Note the confirmation box
>4 - Add a new record
>5 - Click 'Z3950 Search'
>6 - Note no popup
>7 - Apply patch
>8 - Edit existing record
>9 - Note button now says 'Replace record via Z3950 search'
>10 - Add a new blank record
>11 - Note the button says 'Z3950 search'
>12 - Confirm editing/saving/replacing works as in the past
>
>Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../prog/en/modules/cataloguing/addbiblio.tt      | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>index 4fda2747a9..bd7cc15165 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>@@ -83,15 +83,8 @@
>             }
>         });
> 
>-        [%# Only ask for a confirmation if it is an edit %]
>         $("#z3950search").click(function(){
>-            [% IF biblionumber %]
>-                if (confirm(_("Please note that this external search could replace the current record."))){
>-                    PopupZ3950();
>-                }
>-            [% ELSE %]
>-                PopupZ3950();
>-            [% END %]
>+            PopupZ3950();
>         });
> 
>         $("#saverecord").click(function(){
>@@ -587,7 +580,11 @@
>                     [% END # /IF CAN_user_editcatalogue_edit_items %]
> 
>                     [% UNLESS (circborrowernumber) %][%# Hide in fast cataloging %]
>-                        <div class="btn-group"><a class="btn btn-default" href="#" id="z3950search"><i class="fa fa-search"></i> Z39.50/SRU search</a></div>
>+                        [% IF biblionumber %]
>+                            <div class="btn-group"><a class="btn btn-default" href="#" id="z3950search"><i class="fa fa-search"></i> Replace record via Z39.50/SRU search</a></div>
>+                        [% ELSE %]
>+                            <div class="btn-group"><a class="btn btn-default" href="#" id="z3950search"><i class="fa fa-search"></i> Z39.50/SRU search</a></div>
>+                        [% END %]
>                     [% END %]
> 
>                     <div class="btn-group">
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25231: 103398 | 103401 | 103402 | 103421 | 103475