Attachment 103478 Details for Bug 25250 – Bug 25250: (bug 24982 follow-up) Don't disable checkboxes if modification log

[patch] Bug 25250: (bug 24982 follow-up) Don't disable checkboxes if modification log

Bug-25250-bug-24982-follow-up-Dont-disable-checkbo.patch (text/plain), 1.52 KB, created by Jonathan Druart on 2020-04-22 13:52:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-04-22 13:52:28 UTC

Size: 1.52 KB

patch

obsolete

>From 70b0efde331e4c91b237cb2ab23f6aed39e7dd9f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 22 Apr 2020 15:47:17 +0200
>Subject: [PATCH] Bug 25250: (bug 24982 follow-up) Don't disable checkboxes if
> modification log
>
>If we are coming from the "Modification logs" of the patron module we
>should not disable the checkboxes (that are not visible).
>Otherwise the logs are not longer filtered and all are visible.
>
>Test plan:
>0. Don't apply this patch
>1. Modify a patron, add them a fine, and do a checkout
>2. Click the "Modification logs"
>=> You see the Patrons and Circulation logs
>3. Click submit
>=> You see all the logs (KO)
>4. Apply this patch
>5. Click the "Modification logs"
>=> You see the Patrons and Circulation logs
>6. Click submit
>=> You see the Patrons only (KO)
>7. Apply the patch from bug 25249
>8. Click the "Modification logs"
>=> You see the Patrons and Circulation logs
>9. Click submit
>=> You see the Patrons and Circulation logs (OK!)
>---
> tools/viewlog.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/tools/viewlog.pl b/tools/viewlog.pl
>index e6630cf9f8..8b094d6d26 100755
>--- a/tools/viewlog.pl
>+++ b/tools/viewlog.pl
>@@ -50,6 +50,7 @@ my $input = new CGI;
> $debug or $debug = $cgi_debug;
> my $do_it    = $input->param('do_it');
> my @modules  = $input->multi_param("modules");
>+use Data::Printer colored => 1; warn p @modules;
> my $user     = $input->param("user") // '';
> my @actions  = $input->multi_param("actions");
> my @interfaces  = $input->multi_param("interfaces");
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25250: 103478 | 103479 | 103484 | 103486 | 103487 | 103747