Attachment 103479 Details for Bug 25250 – Bug 25250: (bug 24982 follow-up) Don't disable checkboxes if modification log

[patch] Bug 25250: (bug 24982 follow-up) Don't disable checkboxes if modification log

Bug-25250-bug-24982-follow-up-Dont-disable-checkbo.patch (text/plain), 1.79 KB, created by Jonathan Druart on 2020-04-22 13:57:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-04-22 13:57:34 UTC

Size: 1.79 KB

patch

obsolete

>From 687c563907381f0a151d58b51116cea5b7020150 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 22 Apr 2020 15:47:17 +0200
>Subject: [PATCH] Bug 25250: (bug 24982 follow-up) Don't disable checkboxes if
> modification log
>
>If we are coming from the "Modification logs" of the patron module we
>should not disable the checkboxes (that are not visible).
>Otherwise the logs are not longer filtered and all are visible.
>
>Test plan:
>0. Don't apply this patch
>1. Modify a patron, add them a fine, and do a checkout
>2. Click the "Modification logs"
>=> You see the Patrons and Circulation logs
>3. Click submit
>=> You see all the logs (KO)
>4. Apply this patch
>5. Click the "Modification logs"
>=> You see the Patrons and Circulation logs
>6. Click submit
>=> You see the Patrons only (KO)
>7. Apply the patch from bug 25249
>8. Click the "Modification logs"
>=> You see the Patrons and Circulation logs
>9. Click submit
>=> You see the Patrons and Circulation logs (OK!)
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>index 5f7203e876..692c0ef425 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>@@ -329,6 +329,14 @@ fieldset.rows label.viewlog {
>         [% Asset.js("js/members-menu.js") | $raw %]
>     [% END %]
>     [% Asset.js("js/viewlog.js") | $raw %]
>+
>+    [% IF src == "circ" %]
>+        <script>
>+            $(document).ready(function(){
>+                $("input[name='modules']").prop('disabled', false);
>+            });
>+        </script>
>+    [% END %]
> [% END %]
> 
> [% INCLUDE 'intranet-bottom.inc' %]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25250: 103478 | 103479 | 103484 | 103486 | 103487 | 103747