Attachment 103549 Details for Bug 24718 – Bug 24718: Introducing HourBasedHolds system preference

[patch] Bug 24718: Introducing HourBasedHolds system preference

Bug-24718-Introducing-HourBasedHolds-system-prefer.patch (text/plain), 3.52 KB, created by David Nind on 2020-04-23 10:03:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2020-04-23 10:03:53 UTC

Size: 3.52 KB

patch

obsolete

>From e7209229d5600f131a6a6877bdf0d6a7d0e3e2b4 Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Mon, 3 Feb 2020 01:07:24 +0000
>Subject: [PATCH] Bug 24718: Introducing HourBasedHolds system preference
>
>Sponsored-by: Waikato Institute of Technology
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../data/mysql/atomicupdate/bug24718_HourBasedHolds_syspref.perl   | 7 +++++++
> installer/data/mysql/sysprefs.sql                                  | 1 +
> .../prog/en/modules/admin/preferences/circulation.pref             | 6 ++++++
> 3 files changed, 14 insertions(+)
> create mode 100644 installer/data/mysql/atomicupdate/bug24718_HourBasedHolds_syspref.perl
>
>diff --git a/installer/data/mysql/atomicupdate/bug24718_HourBasedHolds_syspref.perl b/installer/data/mysql/atomicupdate/bug24718_HourBasedHolds_syspref.perl
>new file mode 100644
>index 0000000000..8db3900b26
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug24718_HourBasedHolds_syspref.perl
>@@ -0,0 +1,7 @@
>+$DBversion = 'XXX';
>+if( CheckVersion( $DBversion ) ) {
>+    $dbh->do(q{INSERT IGNORE INTO systempreferences (variable,value,explanation,options,type) VALUES ('HourBasedHolds', 0, 'Allow holds to operate on an hourly or minutes basis', NULL, 'YesNo') });
>+
>+    SetVersion( $DBversion );
>+    print "Upgrade to $DBversion done (Bug 24718 - Add HourBasedHolds system preference)\n";
>+}
>diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
>index e39352448c..9f7bd0382e 100644
>--- a/installer/data/mysql/sysprefs.sql
>+++ b/installer/data/mysql/sysprefs.sql
>@@ -228,6 +228,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('HoldsSplitQueue','nothing','nothing|branch|itemtype|branch_itemtype','In the staff client, split the holds view by the given criteria','Choice'),
> ('HoldsToPullStartDate','2',NULL,'Set the default start date for the Holds to pull list to this many days ago','Integer'),
> ('HomeOrHoldingBranch','holdingbranch','holdingbranch|homebranch','Used by Circulation to determine which branch of an item to check with independent branches on, and by search to determine which branch to choose for availability ','Choice'),
>+('HourBasedHolds', 0, NULL, 'Allow holds to operate on an hourly or minutes basis', 'YesNo'),
> ('HouseboundModule',0,'','If ON, enable housebound module functionality.','YesNo'),
> ('HTML5MediaEnabled','not','not|opac|staff|both','Show a tab with a HTML5 media player for files catalogued in field 856','Choice'),
> ('HTML5MediaExtensions','webm|ogg|ogv|oga|vtt','','Media file extensions','free'),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index dbea85baab..5ab2fdd151 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -604,6 +604,12 @@ Circulation:
>             - the last patron to return an item. This setting is independent of opacreadinghistory/AnonymousPatron.
>     Holds policy:
>         -
>+            - pref: HourBasedHolds
>+              choices:
>+                  yes: Allow
>+                  no: "Don't allow"
>+            - holds to operate on an hourly or minutes basis. If enabled, hours and minutes will be considered when placing a hold, and cronjobs will be run hourly.
>+        -
>             - In the staff client, split the holds queue into separate tables by
>             - pref: HoldsSplitQueue
>               choices:
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24718: 99540 | 99541 | 99542 | 99543 | 99544 | 99545 | 99548 | 103521 | 103522 | 103549 | 103550 | 103551 | 103552 | 103553 | 103554 | 103555 | 106270 | 106271 | 106272 | 106273 | 106274 | 106275 | 110084 | 110085 | 110086 | 110087 | 110088 | 110089 | 110090 | 110091 | 110098 | 110137 | 110161 | 110303 | 126559 | 126560 | 126561 | 126562 | 126563 | 126564 | 148293 | 148294 | 148295 | 148296 | 148297 | 148298 | 162474 | 162475 | 162476 | 162477 | 162478 | 162479