Bugzilla – Attachment 103587 Details for
Bug 25166
Add aria-hidden = "true" to Font Awesome icons in the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25166: (follow-up) Update icons generated in JS
Bug-25166-follow-up-Update-icons-generated-in-JS.patch (text/plain), 2.02 KB, created by
Owen Leonard
on 2020-04-23 12:08:32 UTC
(
hide
)
Description:
Bug 25166: (follow-up) Update icons generated in JS
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2020-04-23 12:08:32 UTC
Size:
2.02 KB
patch
obsolete
>From 8a7106f574b46cb385967c141d0e2f0b856bc75e Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 23 Apr 2020 11:50:34 +0000 >Subject: [PATCH] Bug 25166: (follow-up) Update icons generated in JS > >This patch adds aria attributes to Font Awesome icons generated by >JavaScript. The icons won't appear under normal circumstances because >the code for displaying the modal dialog should replace the icons with a >text label. The icons are a fallback. >--- > koha-tmpl/opac-tmpl/bootstrap/js/global.js | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/global.js b/koha-tmpl/opac-tmpl/bootstrap/js/global.js >index 84ee7e844b..ac1bc27af9 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/js/global.js >+++ b/koha-tmpl/opac-tmpl/bootstrap/js/global.js >@@ -65,8 +65,8 @@ function confirmModal(message, title, yes_label, no_label, callback) { > </div>\ > <div class="modal-body"><p></p></div>\ > <div class="modal-footer">\ >- <a href="#" id="bootstrap-confirm-box-modal-submit" class="btn btn-danger"><i class="fa fa-check"></i></a>\ >- <a href="#" id="bootstrap-confirm-box-modal-cancel" data-dismiss="modal" class="btn btn-default"><i class="fa fa-remove"></i></a>\ >+ <a href="#" id="bootstrap-confirm-box-modal-submit" class="btn btn-danger"><i class="fa fa-check" aria-hidden="true"></i></a>\ >+ <a href="#" id="bootstrap-confirm-box-modal-cancel" data-dismiss="modal" class="btn btn-default"><i class="fa fa-remove" aria-hidden="true"></i></a>\ > </div>\ > </div>\ > </div>\ >@@ -86,4 +86,4 @@ function confirmModal(message, title, yes_label, no_label, callback) { > $("#bootstrap-confirm-box-modal-submit").text( yes_label || 'Confirm' ); > $("#bootstrap-confirm-box-modal-cancel").text( no_label || 'Cancel' ); > $("#bootstrap-confirm-box-modal").modal('show'); >-} >\ No newline at end of file >+} >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25166
:
103055
|
103316
|
103524
| 103587