Attachment 103646 Details for Bug 22828 – Bug 22828: Add tests

[patch] Bug 22828: Add tests

Bug-22828-Add-tests.patch (text/plain), 1.49 KB, created by Jonathan Druart on 2020-04-24 11:03:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-04-24 11:03:56 UTC

Size: 1.49 KB

patch

obsolete

>From 38de7d2c71b56b52e39940732da28aa01a63234a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 21 Feb 2020 16:07:23 +0100
>Subject: [PATCH] Bug 22828: Add tests
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t b/t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t
>index 675ddda65a..4ce73d8875 100644
>--- a/t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t
>+++ b/t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t
>@@ -30,7 +30,7 @@ my $schema = Koha::Database->schema();
> use_ok('Koha::SearchEngine::Elasticsearch::Indexer');
> 
> subtest 'create_index() tests' => sub {
>-    plan tests => 4;
>+    plan tests => 5;
>     my $se = Test::MockModule->new( 'Koha::SearchEngine::Elasticsearch' );
>     $se->mock( 'get_elasticsearch_params', sub {
>             my ($self, $sub ) = @_;
>@@ -59,7 +59,10 @@ subtest 'create_index() tests' => sub {
>         MARC::Field->new('245', '', '', 'a' => 'Title')
>     );
>     my $records = [$marc_record];
>-    ok($indexer->update_index([1], $records), 'Update Index');
>+
>+    my $response = $indexer->update_index([1], $records);
>+    is( $response->{errors}, 0, "no error on update_index" );
>+    is( scalar(@{$response->{items}}), 1, "1 item indexed" );
> 
>     is(
>         $indexer->drop_index(),
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22828: 89226 | 89228 | 95096 | 95098 | 95530 | 99040 | 99388 | 103645 | 103646