Attachment 103713 Details for Bug 25276 – Bug 25276: Correct hover style of list share button in the OPAC

[patch] Bug 25276: Correct hover style of list share button in the OPAC

Bug-25276-Correct-hover-style-of-list-share-button.patch (text/plain), 4.41 KB, created by Katrin Fischer on 2020-04-25 22:36:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-04-25 22:36:25 UTC

Size: 4.41 KB

patch

obsolete

>From 2fca168202b16e0a181cf5c968dcdf4937ef0ccf Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 24 Apr 2020 14:24:07 +0000
>Subject: [PATCH] Bug 25276: Correct hover style of list share button in the
> OPAC
>
>This patch adds missing "btn" classes to the OPAC share button so that
>its style is consistent with similar controls.
>
>The patch also makes some general changes to the OPAC CSS to make sure
>link color and hover color are applied with enough specificity. This
>corrects the hover color of the share button but should not change any
>other existing style.
>
>To test you should have the OpacAllowSharingPrivateLists preference
>enabled.
> - Rebuild the OPAC CSS
>   (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
> - Log in to the OPAC as a user with one or more private lists.
> - Go to Lists -> Your lists.
> - In the list of lists there should be a "Share" link for each list.
>   Hovering your mouse pointer over the link should change the style in
>   the same way the "Edit" link does.
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/opac-tmpl/bootstrap/css/src/_mixins.scss |  1 +
> koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss    | 26 +++++++++++++---------
> .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt |  2 +-
> 3 files changed, 18 insertions(+), 11 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/_mixins.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/_mixins.scss
>index 3b529af87d..92ae489c92 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/_mixins.scss
>+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/_mixins.scss
>@@ -1,5 +1,6 @@
> $color: #999999;
> $links: #0076B2;
>+$links-hover: #005580;
> $footer-height: 45px;
> 
> $sci-link-color: #0076B6;
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>index 1ebc3c8303..2fec169b94 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>@@ -58,14 +58,18 @@ $footer-height: 45px;
> }
> 
> a {
>-    color: $links;
>+    &:link,
>+    &:visited {
>+        color: $links;
>+    }
> 
>-    &.cancel {
>-        padding-left: 1em;
>+    &:hover,
>+    &:active {
>+        color: $links-hover;
>     }
> 
>-    &:visited {
>-        color: $links;
>+    &.cancel {
>+        padding-left: 1em;
>     }
> 
>     &.title {
>@@ -834,8 +838,6 @@ ul {
> 
>     .ui-state-default {
>         a {
>-            color: #006699;
>-
>             &:link {
>                 color: #006699;
>             }
>@@ -847,8 +849,6 @@ ul {
>     }
> 
>     .ui-state-hover a {
>-        color: #990033;
>-
>         &:link {
>             color: #990033;
>         }
>@@ -997,10 +997,14 @@ ul {
>     border: 1px solid #AAA;
>     color: #222222;
> 
>-    a,
>+    a:link,
>     a:visited {
>         color: $links;
>     }
>+    a:hover,
>+    a:active {
>+        color: $links-hover;
>+    }
> }
> 
> .ui-widget-header {
>@@ -2320,8 +2324,10 @@ input {
> 
> button {
>     &.btn-link {
>+        color: $links;
>         &:focus,
>         &:hover {
>+            color: $links-hover;
>             text-decoration: none;
>         }
>     }
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>index 92b20baeef..a352cbc5a7 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>@@ -696,7 +696,7 @@
>                                                         </form>
>                                                     [% END %]
>                                                     [% IF s.is_private AND s.can_be_managed( loggedinusernumber ) AND Koha.Preference('OpacAllowSharingPrivateLists') %]
>-                                                        <a href="/cgi-bin/koha/opac-shareshelf.pl?op=invite&shelfnumber=[% s.shelfnumber | uri %]" class="sharelist"><i class="fa fa-share"></i> Share</a>
>+                                                        <a href="/cgi-bin/koha/opac-shareshelf.pl?op=invite&shelfnumber=[% s.shelfnumber | uri %]" class="sharelist btn btn-link"><i class="fa fa-share"></i> Share</a>
>                                                     [% END %]
>                                                     [% IF s.is_shared_with( loggedinusernumber ) %]
>                                                         <form action="opac-shelves.pl" method="post" class="form-inline">
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25276: 103692 | 103695 | 103713