Bugzilla – Attachment 103731 Details for
Bug 24750
Instructor search does not return results if a comma is included after surname or if first name is included
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24750: Instructor Search Results
Bug-24750-Instructor-Search-Results.patch (text/plain), 1.23 KB, created by
Katrin Fischer
on 2020-04-27 06:09:37 UTC
(
hide
)
Description:
Bug 24750: Instructor Search Results
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-04-27 06:09:37 UTC
Size:
1.23 KB
patch
obsolete
>From 3af2a31becf51cf0619f01874f17ca790d0780d2 Mon Sep 17 00:00:00 2001 >From: Joseph Sikowitz <joe@flo.org> >Date: Sat, 18 Apr 2020 16:06:05 -0400 >Subject: [PATCH] Bug 24750: Instructor Search Results > >Adds regex to the split() of the passed parameters to improve searching. > >Test plan >1. Go to Course Reserves module. >2. Press New course button. >3. Make active the instructor search box. >4. Start typing the last name of a patron that exists in your database. >5. At the end of the last name type ", " and try to add a first name. >6. The search should fail. >7. Apply the patch. >8. Follow steps 1-5 again. >9. You should now be able to search using the following methods >9a. surname, firstname >9b. firstname surname > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > circ/ysearch.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/circ/ysearch.pl b/circ/ysearch.pl >index b9e75d0d4d..5db55ff4e1 100755 >--- a/circ/ysearch.pl >+++ b/circ/ysearch.pl >@@ -52,7 +52,7 @@ if ( C4::Context->preference("IndependentBranches") > $limit_on_branch = 1; > } > >-my @parts = split( / /, $query ); >+my @parts = split( /,\s|\s/, $query ); > my @params; > foreach my $p (@parts) { > push( >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24750
:
103206
|
103223
| 103731