Bugzilla – Attachment 103744 Details for
Bug 23081
Make items.issues and deleteditems.issues default to 0 instead of null
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23081: Adjust tests
Bug-23081-Adjust-tests.patch (text/plain), 1.28 KB, created by
Jonathan Druart
on 2020-04-27 09:57:37 UTC
(
hide
)
Description:
Bug 23081: Adjust tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-04-27 09:57:37 UTC
Size:
1.28 KB
patch
obsolete
>From 6e61c298fda769fdf1219864aed98cf2b5050fe5 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 27 Apr 2020 11:55:15 +0200 >Subject: [PATCH] Bug 23081: Adjust tests > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/db_dependent/Items.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t >index c07c66703e..61a691b458 100755 >--- a/t/db_dependent/Items.t >+++ b/t/db_dependent/Items.t >@@ -611,7 +611,7 @@ subtest 'SearchItems test' => sub { > my ($cpl_items_after) = SearchItems( { field => 'homebranch', query => $library1->{branchcode} } ); > is( ( scalar( @$cpl_items_after ) - scalar ( @$cpl_items_before ) ), 1, 'SearchItems should return something' ); > >- # Issues count may be NULL >+ # Issues count = 0 > $filter = { > conjunction => 'AND', > filters => [ >@@ -628,7 +628,7 @@ subtest 'SearchItems test' => sub { > ], > }; > ($items, $total_results) = SearchItems($filter); >- is($total_results, 1, "Search items.issues is NULL with filter issues = 0"); >+ is($total_results, 1, "Search items.issues issues = 0 returns result (items.issues defaults to 0)"); > > $schema->storage->txn_rollback; > }; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23081
:
103601
|
103605
|
103606
|
103608
|
103725
|
103726
|
103741
|
103742
|
103743
| 103744 |
104706