Bugzilla – Attachment 103783 Details for
Bug 25291
Barcode should be escaped everywhere in html code
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25291: Escape barcode in ReturnClaims table display
Bug-25291-Escape-barcode-in-ReturnClaims-table-dis.patch (text/plain), 1.55 KB, created by
Kyle M Hall (khall)
on 2020-04-27 12:59:37 UTC
(
hide
)
Description:
Bug 25291: Escape barcode in ReturnClaims table display
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2020-04-27 12:59:37 UTC
Size:
1.55 KB
patch
obsolete
>From 15776071d91b3820d7dc8deaa6fcf7efff6a8bd7 Mon Sep 17 00:00:00 2001 >From: Didier Gautheron <didier.gautheron@biblibre.com> >Date: Mon, 27 Apr 2020 14:42:49 +0200 >Subject: [PATCH] Bug 25291: Escape barcode in ReturnClaims table display > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >index 8f93aadaf8..1b9b4a213d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >@@ -908,7 +908,13 @@ $(document).ready(function() { > if ( oObj.author ) { > title += ' by ' + oObj.author; > } >- title += ' <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=' + oObj.biblionumber + '&itemnumber=' + oObj.itemnumber + '">' + oObj.barcode + '</a>'; >+ title += ' <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=' >+ + oObj.biblionumber >+ + '&itemnumber=' >+ + oObj.itemnumber >+ + '">' >+ + (oObj.barcode ? oObj.barcode.escapeHtml() : "") >+ + '</a>'; > > return title; > } >-- >2.24.2 (Apple Git-127)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25291
:
103782
|
103783
|
103785
|
103794
|
103796