Attachment 10386 Details for Bug 8267 – [SIGNED-OFF] Bug 8267 - Overdue notices not working

[patch] [SIGNED-OFF] Bug 8267 - Overdue notices not working

0001-Bug-8267-Overdue-notices-not-working.patch (text/plain), 1.81 KB, created by Julian Maurice on 2012-06-20 14:28:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2012-06-20 14:28:07 UTC

Size: 1.81 KB

patch

obsolete

>From 07810f83cac24ecc1f734b84783cee176143e09f Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 18 Jun 2012 10:08:23 -0400
>Subject: [PATCH] Bug 8267 - Overdue notices not working
>
>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>---
> misc/cronjobs/overdue_notices.pl |    8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl
>index cb9ffa2..c93f59b 100755
>--- a/misc/cronjobs/overdue_notices.pl
>+++ b/misc/cronjobs/overdue_notices.pl
>@@ -473,14 +473,14 @@ END_SQL
>                 my $titles = "";
>                 my @items = ();
>                 
>-                my $i = 0;
>+                my $j = 0;
>                 my $exceededPrintNoticesMaxLines = 0;
>                 while ( my $item_info = $sth2->fetchrow_hashref() ) {
>-                    if ( ( !$email || $nomail ) && $PrintNoticesMaxLines && $i >= $PrintNoticesMaxLines ) {
>+                    if ( ( !$email || $nomail ) && $PrintNoticesMaxLines && $j >= $PrintNoticesMaxLines ) {
>                       $exceededPrintNoticesMaxLines = 1;
>                       last;
>                     }
>-                    $i++;
>+                    $j++;
>                     my @item_info = map { $_ =~ /^date|date$/ ? format_date( $item_info->{$_} ) : $item_info->{$_} || '' } @item_content_fields;
>                     $titles .= join("\t", @item_info) . "\n";
>                     $itemcount++;
>@@ -644,7 +644,7 @@ substituted keys and values.
> sub parse_letter {
>     my $params = shift;
>     foreach my $required (qw( letter_code borrowernumber )) {
>-        return unless exists $params->{$required};
>+        return unless ( exists $params->{$required} && $params->{$required} );
>     }
> 
>     my $substitute = $params->{'substitute'} || {};
>-- 
>1.7.10
>

Actions: View | Diff | Splinter Review

Attachments on bug 8267: 10357 | 10386