Attachment 103909 Details for Bug 23070 – Bug 23070: Increment all priorities in 1 query

[patch] Bug 23070: Increment all priorities in 1 query

Bug-23070-Increment-all-priorities-in-1-query.patch (text/plain), 1.01 KB, created by Jonathan Druart on 2020-04-29 10:22:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-04-29 10:22:53 UTC

Size: 1.01 KB

patch

obsolete

>From 518246dace0dce1ad4489d2e686484a7e594521b Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 27 Jan 2020 14:55:54 +0100
>Subject: [PATCH] Bug 23070: Increment all priorities in 1 query
>
>---
> C4/Reserves.pm | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/C4/Reserves.pm b/C4/Reserves.pm
>index 3ffb633331..358ba133c5 100644
>--- a/C4/Reserves.pm
>+++ b/C4/Reserves.pm
>@@ -1993,10 +1993,8 @@ sub RevertWaitingStatus {
> 
>     ## Increment the priority of all other non-waiting
>     ## reserves for this bib record
>-    my $holds = Koha::Holds->search({ biblionumber => $hold->biblionumber, priority => { '>' => 0 } });
>-    while ( my $h = $holds->next ) {
>-        $h->priority( $h->priority + 1 )->store;
>-    }
>+    my $holds = Koha::Holds->search({ biblionumber => $hold->biblionumber, priority => { '>' => 0 } })
>+                           ->update({ priority => \'priority + 1' });
> 
>     ## Fix up the currently waiting reserve
>     $hold->set(
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 23070: 90400 | 97976 | 97977 | 99168 | 99169 | 99170 | 103907 | 103908 | 103909 | 103910 | 104253 | 104261 | 104262 | 104263 | 104264 | 106556 | 106557 | 106558 | 106559