Bugzilla – Attachment 104079 Details for
Bug 25127
Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25127: Correction to tests
Bug-25127-Correction-to-tests.patch (text/plain), 4.47 KB, created by
Nick Clemens (kidclamp)
on 2020-05-01 12:05:16 UTC
(
hide
)
Description:
Bug 25127: Correction to tests
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2020-05-01 12:05:16 UTC
Size:
4.47 KB
patch
obsolete
>From 84087414d96ea1bd692e2d5759fae985f71830a6 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 20 Apr 2020 09:34:19 +0100 >Subject: [PATCH] Bug 25127: Correction to tests > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > t/db_dependent/Overdues.t | 68 ++++++++++++++++++++++++++++++++++++++--------- > 1 file changed, 55 insertions(+), 13 deletions(-) > >diff --git a/t/db_dependent/Overdues.t b/t/db_dependent/Overdues.t >index 12c1cceaa9..e270c52506 100644 >--- a/t/db_dependent/Overdues.t >+++ b/t/db_dependent/Overdues.t >@@ -144,13 +144,13 @@ subtest 'UpdateFine tests' => sub { > my $checkout1 = $builder->build_object( > { > class => 'Koha::Checkouts', >- value => { itemnumber => $item1->itemnumber } >+ value => { itemnumber => $item1->itemnumber, borrowernumber => $patron->id } > } > ); > my $checkout2 = $builder->build_object( > { > class => 'Koha::Checkouts', >- value => { itemnumber => $item2->itemnumber } >+ value => { itemnumber => $item2->itemnumber, borrowernumber => $patron->id } > } > ); > >@@ -430,27 +430,70 @@ subtest 'UpdateFine tests' => sub { > is( $fine3->amount+0, 30, "Third fine reduced" ); > is( $fine3->amountoutstanding+0, 10, "Third fine amount outstanding is reduced" ); > >+ # Ensure calculations work correctly for floats (bug #25127) >+ # 7.2 (maxfine) - 7.2 (total_amount_other) != 8.88178419700125e-16 (ð¢) > t::lib::Mocks::mock_preference( 'MaxFine', '7.2' ); >- my $patron_1 = $builder->build_object( { class => 'Koha::Patrons' } ); >- my $account = $patron_1->account; >- $account->add_debit({ type => 'OVERDUE', amount => '6.99', interface => 'TEST'}); >- $account->add_debit({ type => 'OVERDUE', amount => '.10', interface => 'TEST'}); >- $account->add_debit({ type => 'OVERDUE', amount => '.10', interface => 'TEST'}); >- $account->add_debit({ type => 'OVERDUE', amount => '.01', interface => 'TEST'}); >+ my $patron_1 = $builder->build_object( { class => 'Koha::Patrons' } ); > my $item_1 = $builder->build_sample_item(); >+ my $item_2 = $builder->build_sample_item(); > my $checkout_1 = $builder->build_object( > { > class => 'Koha::Checkouts', >- value => { itemnumber => $item_1->itemnumber, borrowernumber => $patron_1->id } >+ value => { >+ itemnumber => $item_1->itemnumber, >+ borrowernumber => $patron_1->id >+ } >+ } >+ ); >+ my $checkout_2 = $builder->build_object( >+ { >+ class => 'Koha::Checkouts', >+ value => { >+ itemnumber => $item_2->itemnumber, >+ borrowernumber => $patron->id >+ } >+ } >+ ); >+ my $account = $patron_1->account; >+ $account->add_debit( >+ { >+ type => 'OVERDUE', >+ amount => '6.99', >+ issue_id => $checkout_1->issue_id, >+ interface => 'TEST' >+ } >+ ); >+ $account->add_debit( >+ { >+ type => 'OVERDUE', >+ amount => '.10', >+ issue_id => $checkout_1->issue_id, >+ interface => 'TEST' >+ } >+ ); >+ $account->add_debit( >+ { >+ type => 'OVERDUE', >+ amount => '.10', >+ issue_id => $checkout_1->issue_id, >+ interface => 'TEST' >+ } >+ ); >+ $account->add_debit( >+ { >+ type => 'OVERDUE', >+ amount => '.01', >+ issue_id => $checkout_1->issue_id, >+ interface => 'TEST' > } > ); > UpdateFine( > { >- issue_id => $checkout_1->issue_id, >- itemnumber => $item_1->itemnumber, >+ issue_id => $checkout_2->issue_id, >+ itemnumber => $item_2->itemnumber, > borrowernumber => $patron_1->borrowernumber, > amount => '.1', >- due => $checkout_1->date_due >+ due => $checkout_2->date_due > } > ); > $fines = Koha::Account::Lines->search( >@@ -460,6 +503,5 @@ subtest 'UpdateFine tests' => sub { > is( $fines->count, 4, "New amount should be 0 so no fine added" ); > ok( C4::Circulation::AddReturn( $item_1->barcode, $item_1->homebranch, 1), "Returning the item and forgiving fines succeeds"); > >- > $schema->storage->txn_rollback; > }; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25127
:
102826
|
103235
|
103249
|
103253
|
103276
|
103325
|
103326
|
103327
|
103430
|
103431
|
103432
|
104078
| 104079 |
104080