Bugzilla – Attachment 104080 Details for
Bug 25127
Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25127: Use Koha::Number::Price->round for comparison
Bug-25127-Use-KohaNumberPrice-round-for-comparison.patch (text/plain), 1001 bytes, created by
Nick Clemens (kidclamp)
on 2020-05-01 12:05:19 UTC
(
hide
)
Description:
Bug 25127: Use Koha::Number::Price->round for comparison
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2020-05-01 12:05:19 UTC
Size:
1001 bytes
patch
obsolete
>From 50f986e8144494102bc39a253d21050aa0de6e89 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 20 Apr 2020 12:09:27 +0100 >Subject: [PATCH] Bug 25127: Use Koha::Number::Price->round for comparison > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > C4/Overdues.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Overdues.pm b/C4/Overdues.pm >index b6773c2cf1..a9de67d1ee 100644 >--- a/C4/Overdues.pm >+++ b/C4/Overdues.pm >@@ -559,7 +559,7 @@ sub UpdateFine { > > if ( my $maxfine = C4::Context->preference('MaxFine') ) { > my $maxIncrease = $maxfine - $total_amount_other; >- return if $maxIncrease <= 0.00; >+ return if Koha::Number::Price->new($maxIncrease)->round <= 0.00; > if ($accountline) { > if ( ( $amount - $accountline->amount ) > $maxIncrease ) { > my $new_amount = $accountline->amount + $maxIncrease; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25127
:
102826
|
103235
|
103249
|
103253
|
103276
|
103325
|
103326
|
103327
|
103430
|
103431
|
103432
|
104078
|
104079
| 104080