Bugzilla – Attachment 10409 Details for
Bug 7955
Statistics tab in patron module
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7955: Followup: Fix badly use of dbh->quote
0001-Bug-7955-Followup-Fix-badly-use-of-dbh-quote.patch (text/plain), 954 bytes, created by
Jonathan Druart
on 2012-06-21 14:11:45 UTC
(
hide
)
Description:
Bug 7955: Followup: Fix badly use of dbh->quote
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2012-06-21 14:11:45 UTC
Size:
954 bytes
patch
obsolete
>From c3e3d31ab5b168fba85f1a5cd8b7aea63ea645e7 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Thu, 21 Jun 2012 16:09:04 +0200 >Subject: [PATCH 1/1] Bug 7955: Followup: Fix badly use of dbh->quote > >--- > C4/Members/Statistics.pm | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > >diff --git a/C4/Members/Statistics.pm b/C4/Members/Statistics.pm >index 302259c..0f824a5 100644 >--- a/C4/Members/Statistics.pm >+++ b/C4/Members/Statistics.pm >@@ -50,7 +50,10 @@ sub construct_query { > my $fields = C4::Context->preference('StatisticsFields') || 'location|itype|ccode'; > my @select_fields = split '\|', $fields; > my $query = "SELECT COUNT(*) as count_$count"; >- $query .= ", " . C4::Context->dbh->quote( $_ ) for @select_fields; >+ for my $field ( @select_fields ) { >+ C4::Context->dbh->quote( $field ); >+ $query .= ", $field"; >+ } > > $query .= " " . $subquery; > >-- >1.7.7.3 >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=10409">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7955
:
9266
|
9763
|
9771
|
9776
|
10015
|
10223
|
10407
|
10409
|
10410
|
10518
|
10520
|
10746
|
10747
|
10826