Bugzilla – Attachment 104090 Details for
Bug 24522
Nothing happens when trying to add nothing to a list in staff
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24522: Show alert when trying to add nothing to a list in staff
Bug-24522-Show-alert-when-trying-to-add-nothing-to.patch (text/plain), 1.36 KB, created by
Owen Leonard
on 2020-05-01 13:27:50 UTC
(
hide
)
Description:
Bug 24522: Show alert when trying to add nothing to a list in staff
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2020-05-01 13:27:50 UTC
Size:
1.36 KB
patch
obsolete
>From cf50ffd5cb0f701497c09c243eba9b938554d792 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 1 May 2020 13:23:12 +0000 >Subject: [PATCH] Bug 24522: Show alert when trying to add nothing to a list in > staff > >This patch modifies the JavaScript which handles the process of adding >items to a list in the staff client. Error-handling is added in the case >when a set of biblionumbers hasn't been passed to the vShelf function. > >To test, apply the patch and perform a catalog search in the staff >client. > >On the search results page, select any list from the "Add to list" menu >at the top of the search results table without checking any checkboxes. > >You should get an alert, "No item was selected." > >Also test that adding to a list works correctly after selecting one or >more titles. >--- > koha-tmpl/intranet-tmpl/prog/js/basket.js | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/basket.js b/koha-tmpl/intranet-tmpl/prog/js/basket.js >index 5eadc9a6cb..aa5320f844 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/basket.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/basket.js >@@ -452,6 +452,8 @@ function vShelfAdd(biblist) { > bibs.push("biblionumber=" + bibnums[i]); > } > return bibs.join("&"); >+ } else { >+ showListsUpdate(MSG_NO_RECORD_SELECTED); > } > } > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24522
:
104090
|
104130
|
104136