Attachment 104115 Details for Bug 25262 – Bug 25262: [19.05.x] Do not truncate MANUAL_INV in dropdown

[patch] Bug 25262: [19.05.x] Do not truncate MANUAL_INV in dropdown

Bug-25262-1905x-Do-not-truncate-MANUALINV-in-dropd.patch (text/plain), 2.41 KB, created by Lucas Gass (lukeg) on 2020-05-01 15:25:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2020-05-01 15:25:28 UTC

Size: 2.41 KB

patch

obsolete

>From e7371845138f5918fa08739617e00b6fd8f45dd5 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 23 Apr 2020 10:36:20 +0000
>Subject: [PATCH] Bug 25262: [19.05.x] Do not truncate MANUAL_INV in dropdown
>
>There is an issue in that historic values will still be truncated, but recent values are not.
>I feel the cash register report should reflect recent transactions over historic, and the historic are a data cleanup issue
>
>To test:
>1 - Add a MANUAL_INV value with more than 5 characters 'INCREDIBLE_HULK'
>2 - Add a manual invoice to a patron's acccount using this value
>3 - Note the full code displays in patrons account
>4 - Browse to Reports->Cash register
>5 - Search for today's date, the value you createed, and all libraries
>6 - No results returned
>7 - Apply patch
>8 - Repeat 5
>9 - The transaction shows
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> .../intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt   | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt
>index 25abde2da4..f4cd275cd6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt
>@@ -121,11 +121,10 @@
>                         [% END %]
> 
>                         [% FOREACH manualinv IN manualinv_types %]
>-                            [% value_manualinv = manualinv.authorised_value|truncate(5, '') %]
>-                            [% IF transaction_type == value_manualinv %]
>-                            <option value="[% value_manualinv | html %]" selected="selected">[% manualinv.authorised_value | html %]</option>
>+                            [% IF transaction_type == manualinv.authorised_value %]
>+                            <option value="[% manualinv.authorised_value | html %]" selected="selected">[% manualinv.authorised_value | html %]</option>
>                             [% ELSE %]
>-                            <option value="[% value_manualinv | html %]">[% manualinv.authorised_value | html %]</option>
>+                            <option value="[% manualinv.authorised_value | html %]">[% manualinv.authorised_value | html %]</option>
>                             [% END %]
>                         [% END %]
>                     </select>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25262: 103561 | 104082 | 104115 | 104137